Skip to content

spp_dci_compliance: INSECURE_SETTINGS names and descriptions are not translatable #530

Description

@gonzalesedwin1123

spp_dci_compliance/models/security_warning.py INSECURE_SETTINGS holds the user-visible text of the security-warning systray item ("Allow Unsigned Requests", "DCI signature verification is disabled. Any request will be accepted without cryptographic verification.", and so on) as plain str in a class-level constant. They are returned as-is by get_security_warnings() and rendered by the systray dropdown, so the panel stays English in every language. The JS-side strings (_t) and the XML template are translatable since #527; these Python strings are the remaining bulk of the panel text.

Because the entries live in a class-level constant, they need lazy translation: keep the constant as message ids and translate at get_security_warnings() time with self.env._(), or use LazyTranslate. Update the .pot afterwards.

Also the summary message (summarize()) uses the English-only plural form "%s DCI security setting(s) are in development mode"; use a proper plural or drop the field, which the template never renders (see the sibling systray follow-up).

Refs: #450, #527.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions