editoast: derive: replace #[view_error(name)] by path - #18770
Merged
Merged
Conversation
leovalais
enabled auto-merge
September 24, 2026 16:03
leovalais
force-pushed
the
lva/nqltzwsptnwm
branch
from
September 24, 2026 16:08
2c6737e to
87521e8
Compare
Use the Rust path syntax and let the macro turn it into a label. Avoids confusion about which separator to use (`:` vs `::`). The name `path` also emphasizes that we can re-scope errors. Signed-off-by: Léo VALAIS <leovalais+git@proton.me>
leovalais
force-pushed
the
lva/nqltzwsptnwm
branch
from
September 24, 2026 16:40
87521e8 to
b42b5df
Compare
Contributor
|
woshilapin
approved these changes
Sep 25, 2026
woshilapin
left a comment
woshilapin
left a comment
Contributor
There was a problem hiding this comment.
Seems reasonable to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the Rust path syntax and let the macro turn it into a label. Avoids confusion about which separator to use (
:vs::). The namepathalso emphasizes that we can re-scope errors.I find that better, but I admit it's a little opinionated. Lmk.
Also acts as a middle ground for #11545 (comment).