front: update propagation behaviour - #18757
Merged
Merged
Conversation
Signed-off-by: aschantraine <aschantraine@free.fr>
Signed-off-by: aschantraine <aschantraine@free.fr>
Signed-off-by: aschantraine <aschantraine@free.fr>
Applying a change with atThisWaypoint mode on a requested departure now moves the waypoint arrival and keep the stop duration. Signed-off-by: aschantraine <aschantraine@free.fr>
Signed-off-by: aschantraine <aschantraine@free.fr>
In this mode, the edited time is the only one to move. The stop duration absorbs the change. Signed-off-by: aschantraine <aschantraine@free.fr>
This was
linked to
issues
Sep 23, 2026
aschantraine
requested review from
Pivouane,
SharglutDev and
Wadjetz
and removed request for
Wadjetz
September 23, 2026 18:44
aschantraine
marked this pull request as ready for review
September 23, 2026 19:00
Contributor
SharglutDev
approved these changes
Sep 25, 2026
SharglutDev
left a comment
Contributor
There was a problem hiding this comment.
Lgtm and tested, great work !
Contributor
|
@maelysLeratRosso regarding my above comment on deltas, we discussed with @aschantraine and the app behavior looked fine. Could you double check these two cases delta to see if it's really the value you expect ? :) If yes, you can find a fix in a followup PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This PR changes the behaviour of some propagation modes and creates a new one:
fromDeparture: apply to an arrival, this mode doesn't change the waypoint departure anymore, the stop duration absorb the deltaatThisWaypoint: apply to a departure, this mode doesn't change the stop duration anymore, the arrival absorbs the deltaatThisTime: new mode that only change the edited time, the stop duration absorbs the delta (not the other time of the waypoint by opposition toatThisWaypoint)Since there is no design for the new mode, I chose to keep the same icon as
atThisWaypointto express that only the edited point is touched. Feel free to suggest another icon.The first 3 tabs of this doc are now implemented.