Skip to content

front: update propagation behaviour - #18757

Merged
SharglutDev merged 6 commits into
devfrom
ace/update-propagation-behaviour
Sep 25, 2026
Merged

SharglutDev merged 6 commits into
devfrom
ace/update-propagation-behaviour

Conversation

@aschantraine

@aschantraine aschantraine commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

This PR changes the behaviour of some propagation modes and creates a new one:

  • fromDeparture: apply to an arrival, this mode doesn't change the waypoint departure anymore, the stop duration absorb the delta
  • atThisWaypoint: apply to a departure, this mode doesn't change the stop duration anymore, the arrival absorbs the delta
  • atThisTime: new mode that only change the edited time, the stop duration absorbs the delta (not the other time of the waypoint by opposition toatThisWaypoint)

Since there is no design for the new mode, I chose to keep the same icon as atThisWaypoint to express that only the edited point is touched. Feel free to suggest another icon.

The first 3 tabs of this doc are now implemented.

Signed-off-by: aschantraine <aschantraine@free.fr>
Signed-off-by: aschantraine <aschantraine@free.fr>
Signed-off-by: aschantraine <aschantraine@free.fr>
Applying a change with atThisWaypoint mode on a requested departure now moves the waypoint arrival and keep the stop duration.

Signed-off-by: aschantraine <aschantraine@free.fr>
Signed-off-by: aschantraine <aschantraine@free.fr>
In this mode, the edited time is the only one to move. The stop duration absorbs the change.

Signed-off-by: aschantraine <aschantraine@free.fr>
@github-actions github-actions Bot added the area:front Work on Standard OSRD Interface modules label Sep 23, 2026
@aschantraine
aschantraine requested review from Pivouane, SharglutDev and Wadjetz and removed request for Wadjetz September 23, 2026 18:44
@aschantraine
aschantraine marked this pull request as ready for review September 23, 2026 19:00
@aschantraine
aschantraine requested a review from a team as a code owner September 23, 2026 19:00
@aschantraine aschantraine moved this to Awaiting merge in Board PI 21 Sep 23, 2026

@Wadjetz Wadjetz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SharglutDev

Copy link
Copy Markdown
Contributor

Thank you for the PR ! Only tested it for now.

Tabs 1 & 2 from the doc works as expected 💪

Tab 3 (departure with stop):

  • atThisTime
Capture d’écran 2026-09-24 à 18 14 40

The delta displayed doesn't match what's asked (the new schedule are ok though):
Capture d’écran 2026-09-24 à 18 14 29

It seems to count : old value - (new value + current stop).
This is also not the expected delta for the atThisWaypoint option (23:25 instead of 23:35)

  • atThisWaypoint
Capture d’écran 2026-09-24 à 18 36 01

For this one, I'm a bit confused regarding what it's expected because it seems like the delta should represents what will change for the arrival ? (that's is asked for the '18:10' test) 😵‍💫

But we see this:
Capture d’écran 2026-09-24 à 18 36 16

The rest of tab 3 is good ✅

@SharglutDev SharglutDev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, great work !

Comment thread front/src/modules/timesStops/helpers/timePropagation.ts Outdated
Comment thread front/src/modules/timesStops/helpers/timePropagation.ts
@SharglutDev
SharglutDev added this pull request to the merge queue Sep 25, 2026
@SharglutDev

Copy link
Copy Markdown
Contributor

@maelysLeratRosso regarding my above comment on deltas, we discussed with @aschantraine and the app behavior looked fine. Could you double check these two cases delta to see if it's really the value you expect ? :) If yes, you can find a fix in a followup PR.

Merged via the queue into dev with commit 5ff2fa1 Sep 25, 2026
74 of 75 checks passed
@SharglutDev
SharglutDev deleted the ace/update-propagation-behaviour branch September 25, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:front Work on Standard OSRD Interface modules

Projects

Status: Awaiting Validation

Development

Successfully merging this pull request may close these issues.

front: add a new propagation mode "at this time" front: "from departure" at a requested arrival should update the stopping time of the waypoint

3 participants