Skip to content

editoast: add ViewError to fonts view - #18731

Merged
neigeantre merged 2 commits into
devfrom
abo/editoast/add-view-error-to-fonts-view
Sep 28, 2026
Merged

neigeantre merged 2 commits into
devfrom
abo/editoast/add-view-error-to-fonts-view

Conversation

@neigeantre

Copy link
Copy Markdown
Contributor

No description provided.

@neigeantre neigeantre self-assigned this Sep 22, 2026
@github-actions github-actions Bot added area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service kind:api-change labels Sep 22, 2026
@neigeantre
neigeantre added this pull request to stack #18732 September 22, 2026 16:17
@neigeantre
neigeantre force-pushed the abo/editoast/add-view-error-to-fonts-view branch from 49daa43 to fb85823 Compare September 23, 2026 09:51
@github-actions github-actions Bot removed the area:front Work on Standard OSRD Interface modules label Sep 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ API changes

This Pull Request introduces some changes in the API:

  • please own it: notify or even prepare dedicated PR(s) to consumer projects

Base automatically changed from lva/view-error-proc-macro to dev September 23, 2026 11:54
@leovalais
leovalais force-pushed the abo/editoast/add-view-error-to-fonts-view branch from fb85823 to 71e70fc Compare September 23, 2026 11:54
@neigeantre
neigeantre marked this pull request as ready for review September 23, 2026 12:16
@neigeantre
neigeantre requested a review from a team as a code owner September 23, 2026 12:16
@neigeantre
neigeantre force-pushed the abo/editoast/add-view-error-to-fonts-view branch from 71e70fc to 38e44ed Compare September 23, 2026 12:17
@github-actions github-actions Bot added the area:front Work on Standard OSRD Interface modules label Sep 23, 2026
@neigeantre
neigeantre force-pushed the abo/editoast/add-view-error-to-fonts-view branch from 38e44ed to 17fccae Compare September 23, 2026 12:18
@github-actions github-actions Bot removed the area:front Work on Standard OSRD Interface modules label Sep 23, 2026
@neigeantre
neigeantre force-pushed the abo/editoast/add-view-error-to-fonts-view branch 2 times, most recently from 3809390 to 6570db0 Compare September 23, 2026 12:37

@leovalais leovalais left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Comment thread editoast/src/views/fonts.rs Outdated
Comment thread editoast/openapi.yaml

@QuentinHayK QuentinHayK left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread editoast/src/views/fonts.rs Outdated
@neigeantre neigeantre changed the title editoast: add view error to fonts view editoast: add ViewError to fonts view Sep 23, 2026
@neigeantre
neigeantre force-pushed the abo/editoast/add-view-error-to-fonts-view branch from ed75750 to c3ae197 Compare September 23, 2026 14:44
@neigeantre
neigeantre requested a review from a team as a code owner September 23, 2026 14:44
@github-actions github-actions Bot added the area:front Work on Standard OSRD Interface modules label Sep 23, 2026

@leovalais leovalais left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing en/errors.json

Comment thread editoast/src/views/fonts.rs Outdated
Comment thread front/public/locales/fr/errors.json Outdated
@neigeantre
neigeantre force-pushed the abo/editoast/add-view-error-to-fonts-view branch 3 times, most recently from 2149bcc to eb53b2c Compare September 23, 2026 15:21
Comment thread editoast/src/views/documents.rs Outdated
@neigeantre
neigeantre force-pushed the abo/editoast/add-view-error-to-fonts-view branch 2 times, most recently from 0d84bf5 to 14b6d93 Compare September 23, 2026 15:53
@neigeantre
neigeantre force-pushed the abo/editoast/add-view-error-to-fonts-view branch from 14b6d93 to eaa66f0 Compare September 25, 2026 16:55
Signed-off-by: Arthur Bougeard <covillesheer@gmail.com>
Signed-off-by: Arthur Bougeard <covillesheer@gmail.com>
@neigeantre
neigeantre force-pushed the abo/editoast/add-view-error-to-fonts-view branch from eaa66f0 to 0a1d6d5 Compare September 25, 2026 17:01
@neigeantre
neigeantre added this pull request to the merge queue Sep 28, 2026
Merged via the queue into dev with commit 9891898 Sep 28, 2026
40 checks passed
@neigeantre
neigeantre deleted the abo/editoast/add-view-error-to-fonts-view branch September 28, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules kind:api-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants