core, editoast: add topological to geometric offset projection on /path endpoint by neigeantre · Pull Request #17476 · OpenRailAssociation/osrd

neigeantre · 2026-07-01T12:53:46Z

Change TrainPath interface in core to access the path's partial track sections
Add property geom_projection to core and editoast APIs
Test the computing of geom_projection in core

Important

The length computed in core for the LineString geometry is not exact, so it differs from the one we compute in the front (which is exact, using @turf/length package, implementing Haversine formula).

So we decided to implement the same formula in core, only for the loading of the infra, and being careful as to where we also have to make corresponding changes.

github-actions · 2026-07-01T12:54:04Z

⚠️ API changes

This Pull Request introduces some changes in the API:

please own it: notify or even prepare dedicated PR(s) to consumer projects

bougue-pe

👍 LTGM overall, thanks for the tests.
Only comments on the form.

bougue-pe · 2026-07-03T16:10:19Z

+#[derive(Debug, Clone, Serialize, Deserialize, ToSchema)]
+#[schema(as = CorePropertyGeometryProjection)]
+pub struct GeometryProjection {
+    /// Topologic offsets in millimeters.


Looks like the en-US word is topological.
Ditto for all this PR (code + commits + github).

done in the code, will do it in commit messages when I rebase

I let you do a ctrl+F topologic but spotted leftovers in code, PR title, etc.
Anyway, this comment is a reminder for what's left, currently, so letting this open.

…_properties endpoint - Change `TrainPath` interface in core to access the path's partial track sections - Add property `geom_projection` to core and editoast APIs - Test the computing of `geom_projection` in core Signed-off-by: Arthur Bougeard <covillesheer@gmail.com>

bougue-pe

Waiting for the switch to haversine, but it looks good so far :)

bougue-pe · 2026-09-24T07:08:49Z


+data class GeometricProjection(
+    @Json(name = "topo_offsets") val topoOffsets: List<Offset<PhysicsPath>>,
+    @Json(name = "geom_offsets") val geomOffsets: List<Offset<RJSLineString>>,


It's about to become RJSMutliLineString 😅

I'd say the first one merged wins (but notify the other to propagate the change)

thanks for this, I’ll be watching if that PR is merged before this one

bougue-pe · 2026-09-24T07:16:46Z

+        for (i in 0..<(topoOffsets.size - 1)) {
+            assert(topoOffsets[i] <= topoOffsets[i + 1])
+            assert(geomOffsets[i] <= geomOffsets[i + 1])


nit: It would be nicer to trigger the loop only inside asserts (spare the loop if assert is not triggered).

I'd probably go using .zipWithNext() and .all{} to do that.

bougue-pe · 2026-09-24T08:09:04Z

+        val rangeTopoLength = range.length
+        val trackSectionTopoLength = range.objectLength
+        val trackSectionGeomLength = getTrackSectionGeometricLength(range.value.value)
+        topoOffsets.addLast(topoOffsets.last() + rangeTopoLength)
+        val proportion = rangeTopoLength / trackSectionTopoLength.distance
+        val rangeGeomLength = trackSectionGeomLength.distance * proportion
+        geomOffsets.addLast(geomOffsets.last() + rangeGeomLength)


nit: it would be easier to read if "stories" have as little overlap as possible (just reordering below).

Suggested change

val rangeTopoLength = range.length

val trackSectionTopoLength = range.objectLength

val trackSectionGeomLength = getTrackSectionGeometricLength(range.value.value)

topoOffsets.addLast(topoOffsets.last() + rangeTopoLength)

val proportion = rangeTopoLength / trackSectionTopoLength.distance

val rangeGeomLength = trackSectionGeomLength.distance * proportion

geomOffsets.addLast(geomOffsets.last() + rangeGeomLength)

val rangeTopoLength = range.length

topoOffsets.addLast(topoOffsets.last() + rangeTopoLength)

val trackSectionTopoLength = range.objectLength

val proportion = rangeTopoLength / trackSectionTopoLength.distance

val trackSectionGeomLength = getTrackSectionGeometricLength(range.value.value)

val rangeGeomLength = trackSectionGeomLength.distance * proportion

geomOffsets.addLast(geomOffsets.last() + rangeGeomLength)

bougue-pe · 2026-09-24T08:18:15Z

+        val firstTrackRangeLength = (firstTrackRangeProportion * trackTA0GeoLength).toLong()
+        val secondTrackRangeLength = trackTA1GeoLength.toLong()


Feels like you can avoid * 1000 and .toLong() using Double.meters to get a Distance.

I removed this part

bougue-pe · 2026-09-24T08:23:11Z

+        val chunks = rawInfra.getTrackSectionChunks(trackSection)
+        return chunks
+            .map {
+                Length<RJSLineString>(Distance.fromMeters(rawInfra.getTrackChunkGeom(it).length))


nit: shorter

Suggested change

Length<RJSLineString>(Distance.fromMeters(rawInfra.getTrackChunkGeom(it).length))

Length<RJSLineString>(rawInfra.getTrackChunkGeom(it).length.meters)

…n /path_properties endpoint

neigeantre self-assigned this Jul 1, 2026

neigeantre requested review from a team as code owners July 1, 2026 12:53

neigeantre requested a review from Khoyo July 1, 2026 12:53

github-actions Bot added area:core Work on Core Service area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service kind:api-change labels Jul 1, 2026

woshilapin approved these changes Jul 1, 2026

View reviewed changes

Comment thread editoast/core_client/src/path_properties.rs

Comment thread editoast/core_client/src/path_properties.rs

neigeantre force-pushed the abo/core-editoast/topologic-to-geometric-projection branch from 9ee4581 to 1ce4952 Compare July 1, 2026 13:19

neigeantre requested a review from a team as a code owner July 1, 2026 13:19

neigeantre force-pushed the abo/core-editoast/topologic-to-geometric-projection branch from 1ce4952 to 5400d80 Compare July 1, 2026 14:26

github-actions Bot added the area:integration-tests Work on Integration test, by nature related to different services label Jul 1, 2026

neigeantre force-pushed the abo/core-editoast/topologic-to-geometric-projection branch 3 times, most recently from 8f804c0 to 904e545 Compare July 2, 2026 12:30

bougue-pe reviewed Jul 3, 2026

View reviewed changes

neigeantre marked this pull request as draft July 10, 2026 13:25

neigeantre force-pushed the abo/core-editoast/topologic-to-geometric-projection branch from 5cac885 to a9c04c1 Compare September 21, 2026 12:37

neigeantre changed the title ~~core, editoast: add topologic to geometric offset projection on /path endpoint~~ [WIP] core, editoast: add topologic to geometric offset projection on /path endpoint Sep 21, 2026

bougue-pe reviewed Sep 24, 2026

View reviewed changes

neigeantre changed the title ~~[WIP] core, editoast: add topologic to geometric offset projection on /path endpoint~~ [WIP] core, editoast: add topological to geometric offset projection on /path endpoint Sep 24, 2026

fixup! core, editoast: add topologic to geometric offset projection o…

b31a832

…n /path_properties endpoint

neigeantre force-pushed the abo/core-editoast/topologic-to-geometric-projection branch from b27f512 to b31a832 Compare September 25, 2026 08:54

neigeantre added this pull request to stack #18780 September 25, 2026 13:17

neigeantre changed the title ~~[WIP] core, editoast: add topological to geometric offset projection on /path endpoint~~ core, editoast: add topological to geometric offset projection on /path endpoint Sep 25, 2026

neigeantre marked this pull request as ready for review September 25, 2026 14:03

neigeantre requested a review from bougue-pe September 25, 2026 17:02

		val firstTrackRangeLength = (firstTrackRangeProportion * trackTA0GeoLength).toLong()
		val secondTrackRangeLength = trackTA1GeoLength.toLong()

	Length<RJSLineString>(Distance.fromMeters(rawInfra.getTrackChunkGeom(it).length))
	Length<RJSLineString>(rawInfra.getTrackChunkGeom(it).length.meters)

Conversation

neigeantre commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026

⚠️ API changes

Uh oh!

Uh oh!

Uh oh!

bougue-pe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bougue-pe Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bougue-pe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bougue-pe Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

neigeantre commented Jul 1, 2026 •

edited

Loading

bougue-pe Jul 3, 2026 •

edited

Loading

bougue-pe Sep 24, 2026 •

edited

Loading