hoist magic numbers to TrackLabConstants and named local constants - #8
Merged
Conversation
Create src/TrackLabConstants.ts for cross-cutting shared constants (panel corner radius, screen layout offsets, track symbol ASCII codes, model-view transform thresholds, webcam dimensions). In every view/model file, replace inline numeric literals with named module-level constants — arrow dimensions, drag speeds, font sizes, line widths, dash patterns, spacing values, button margins, precision thresholds, and more. https://claude.ai/code/session_01Pj5aaDUhUVCGbKAqPh8SaF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create src/TrackLabConstants.ts for cross-cutting shared constants
(panel corner radius, screen layout offsets, track symbol ASCII codes,
model-view transform thresholds, webcam dimensions).
In every view/model file, replace inline numeric literals with named
module-level constants — arrow dimensions, drag speeds, font sizes,
line widths, dash patterns, spacing values, button margins, precision
thresholds, and more.
https://claude.ai/code/session_01Pj5aaDUhUVCGbKAqPh8SaF