refactor: extract GraphRenderer and TableRenderer from god objects - #75
Merged
Conversation
ConfigurableGraph (805 → ~440 lines): - New GraphRenderer.ts owns all bamboo chart/grid/button rendering nodes, the clipped data container, axis labels, and axis interaction regions. - ConfigurableGraph is now a thin coordinator: creates ChartTransform, instantiates sub-modules, wires listeners, and delegates rendering and resize updates to GraphRenderer. - Extracted mapDataPoints() as a module-level function so setTrackData() no longer mixes data-mapping logic with plot management. DataTableNode (839 → ~290 lines): - New TableRenderer.ts owns all HTML DOM construction and incremental-update state (lastTrackIds, lastUnit, tableBodyRef, frameRowMap, maxRenderedFrame). - TableRenderer.update() encapsulates the structural-vs-incremental decision previously nested deep inside the DataTableNode constructor. - DataTableNode now focuses solely on SceneryStack integration: Panel, drag listener, resize handles, and reactive property wiring. https://claude.ai/code/session_01Ns5vMGXj1wSUU3pwzTfYco
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigurableGraph (805 → ~440 lines):
DataTableNode (839 → ~290 lines):
https://claude.ai/code/session_01Ns5vMGXj1wSUU3pwzTfYco