Skip to content

fix: surface errors from silent catch blocks in webcam flow #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veillette merged 2 commits into from
Feb 28, 2026
Merged

fix: surface errors from silent catch blocks in webcam flow #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8815359
fix: surface errors from silent catch blocks in webcam flow
claude Feb 28, 2026
487d09c
fix: revoke blob URL on reset to prevent memory leak
claude Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/screen-name/view/VideoPlayerNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,10 @@ export class VideoPlayerNode extends Node {

/** Reset the video source selection to the initial state. */
public reset(): void {
if (this.currentBlobUrl) {
URL.revokeObjectURL(this.currentBlobUrl);
this.currentBlobUrl = null;
}
this.videoSourceControlNode.reset();
this.videoElement.removeAttribute("src");
this.videoElement.load();
Expand Down
8 changes: 2 additions & 6 deletions src/screen-name/view/VideoSourceControlNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ export class VideoSourceControlNode extends HBox {
const fps = frameCount > 0 && duration > 0 ? frameCount / duration : DEFAULT_FRAME_RATE;
storeAndLoad(duration, fps, frameCount > 0 ? frameCount : undefined);
})
.catch(() => storeAndLoad(0));
.catch(() => storeAndLoad(0)); // Frame counting failed; load with unknown duration (0)
} else {
// Read duration via a temporary video element, then store and load
const tempUrl = URL.createObjectURL(blob);
Expand Down Expand Up @@ -506,11 +506,7 @@ export class VideoSourceControlNode extends HBox {
listener: async () => {
isPlayingProperty.value = false;
this.webcamPanel.visible = true;
try {
await this.webcamPanel.open();
} catch {
this.webcamPanel.visible = false;
}
await this.webcamPanel.open();
},
});

Expand Down
22 changes: 13 additions & 9 deletions src/screen-name/view/WebcamPanel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,16 +288,20 @@ export class WebcamPanel extends Node {
this.setStatus(this.webcamStrings.requestingAccessStringProperty.value);
this._startButton.enabled = false;

const granted = await this.recorder.requestPermission();
if (!granted) {
try {
const granted = await this.recorder.requestPermission();
if (!granted) {
this.setStatus(this.webcamStrings.accessDeniedStringProperty.value);
return;
}

await this.populateCameras();
await this.recorder.startPreview(this.previewElement, this.cameraSelect.value || undefined);
this.clearStatus();
this._startButton.enabled = true;
} catch {
this.setStatus(this.webcamStrings.accessDeniedStringProperty.value);
return;
}

await this.populateCameras();
await this.recorder.startPreview(this.previewElement, this.cameraSelect.value || undefined);
this.clearStatus();
this._startButton.enabled = true;
}

// Reset visibility to preview phase without touching the camera stream.
Expand Down Expand Up @@ -425,7 +429,7 @@ export class WebcamPanel extends Node {
blob = fixed.blob;
duration = fixed.duration;
} catch {
// Fall back to the raw blob with unknown duration
this.clearStatus(); // Metadata fix failed; continue with raw blob and unknown duration
}
}

Expand Down