Add factory method for RectangularPushButton with consistent sizing a… - #44
Merged
Merged
Conversation
…nd touch areas
Introduces createTrackLabButton() in TrackLabButton.ts — a single factory that
gives every button the same flat appearance, dark base colour, x/y margins, and
enlarged touch/mouse target areas without requiring callers to repeat boilerplate.
Key changes:
- TrackLabConstants.ts: add BUTTON_MIN_CONTENT_SIZE (18 px), TOUCH_AREA_DILATION
(5 px) and MOUSE_AREA_DILATION (2 px) constants
- TrackLabButton.ts (new): factory function + icon helpers
- sizeContent() wraps every icon in a Node with HStrut/VStrut so all icon
buttons share an identical 18×18 content floor; larger content (text labels)
simply overflows naturally
- makeDownloadIcon() replaces the plain ⬇ unicode glyph with a proper
Path-based arrow-into-tray icon for cleaner rendering and better recognisability
- makeUploadIcon() extracted from VideoSourceControlNode for reuse
- All seven call sites updated to use createTrackLabButton():
VideoSourceControlNode (download + upload), PlaybackControlsNode (rewind),
TrackListPanel (add-track + trash), DataTableNode (CSV export),
WebcamPanel (record start + stop + use-video)
- CameraButton in VideoSourceControlNode gets manual touch/mouse dilation to
match the factory defaults (CameraButton is not a RectangularPushButton)
https://claude.ai/code/session_01WUtXMUhjfvG784s5q1DXag
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nd touch areas
Introduces createTrackLabButton() in TrackLabButton.ts — a single factory that gives every button the same flat appearance, dark base colour, x/y margins, and enlarged touch/mouse target areas without requiring callers to repeat boilerplate.
Key changes:
https://claude.ai/code/session_01WUtXMUhjfvG784s5q1DXag