Hoist magic numbers and strings across view and graph files - #40
Merged
Conversation
- TrackLabConstants: add DIGITIZING_DIM_OPACITY (shared opacity for digitizing lock-out)
- strings_en/fr + StringManager: add i18n strings for calibration, coordSystem, videoSource, webcam, kinematicsGraph, playback, and autoTracker categories
- SimScreenView: extract four layout margin constants
- PlaybackControlsNode: extract REWIND_BUTTON_ICON_SIZE; use i18n for duration/seconds strings
- VideoSourceControlNode: extract DOWNLOAD_ICON_FONT_SIZE; use i18n for button accessibleNames
- CoordinateSystemNode: use DIGITIZING_DIM_OPACITY; use i18n for axis labels and accessibleNames
- CalibrationToolNode: use DIGITIZING_DIM_OPACITY; use i18n for endpoint/warning strings
- AutoTrackerNode: extract LABELS_SPACING; use i18n for accessibleName and error fallback string
- ConfigurableGraph: replace inline literals in resizeGraph() with named constants already defined at file top
- DataTableNode: extract CSS dimension constants (border-radius, padding) and DOWNLOAD_ICON_FONT_SIZE
- DigitizingOverlayNode: extract MAG_SHADOW_OFFSET_X/Y/BLUR for box-shadow CSS
- KinematicsGraphNode: extract VBOX_SPACING, TRACK_SELECTOR_FONT, TRACK_COMBO_X/Y_MARGIN, TRACK_SELECTOR_SPACING; use i18n for "Track:", "No tracks", "Track {{symbol}}"
- WebcamPanel: extract CAMERA_SELECT_FONT/PADDING, TIMER_INTERVAL_MS, SECONDS_PER_MINUTE; use i18n for all button accessibleNames, status strings, and FPS estimate display
https://claude.ai/code/session_01P9UscuE1hestbaoHgVZKZD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01P9UscuE1hestbaoHgVZKZD