Skip to content

fix: add explicit type annotations to scripts to resolve lint warnings #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veillette merged 2 commits into from
Feb 22, 2026
Merged

fix: add explicit type annotations to scripts to resolve lint warnings #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c085a9e
fix: add explicit type annotations to scripts to resolve lint warnings
claude Feb 22, 2026
2c4dfce
fix: disable useExplicitType lint rule for src/ via biome override
claude Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,18 @@
"files": {
"includes": ["**/*.ts", "**/*.js", "**/*.json", "**/*.html", "!dist"]
},
"overrides": [
{
"includes": ["src/**"],
"linter": {
"rules": {
"nursery": {
"useExplicitType": "off"
}
}
}
}
],
"javascript": {
"formatter": {
"quoteStyle": "double",
Expand Down
4 changes: 2 additions & 2 deletions scripts/bouncingBallToSVG.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ ${circles}
</svg>`;
}

const points = computeSnapshots();
const svg = buildSvg(points);
const points: Point[] = computeSnapshots();
const svg: string = buildSvg(points);

// Write to public/icons/icon.svg (source for PNG icon generation)
const outputPath = "public/icons/icon.svg";
Expand Down
14 changes: 7 additions & 7 deletions scripts/generate-icons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ import { fileURLToPath } from "node:url";
import pngToIco from "png-to-ico";
import sharp from "sharp";

const Dirname = dirname(fileURLToPath(import.meta.url));
const root = resolve(Dirname, "..");
const Dirname: string = dirname(fileURLToPath(import.meta.url));
const root: string = resolve(Dirname, "..");

const svgBuffer = readFileSync(resolve(root, "public/icons/icon.svg"));
const svgBuffer: Buffer = readFileSync(resolve(root, "public/icons/icon.svg"));

const pngIcons = [
const pngIcons: Array<{ name: string; size: number }> = [
{ name: "icons/apple-touch-icon.png", size: 180 },
{ name: "icons/icon-192.png", size: 192 },
{ name: "icons/icon-512.png", size: 512 },
Expand All @@ -22,14 +22,14 @@ for (const { name, size } of pngIcons) {
}

// Generate multi-size favicon.ico (16, 32, 48, 64)
const faviconSizes = [16, 32, 48, 64];
const faviconSizes: number[] = [16, 32, 48, 64];
const faviconPngs: Buffer[] = [];

for (const size of faviconSizes) {
const pngBuffer = await sharp(svgBuffer).resize(size, size).png().toBuffer();
faviconPngs.push(pngBuffer);
}

const icoBuffer = await pngToIco(faviconPngs);
const faviconDest = resolve(root, "public", "favicon.ico");
const icoBuffer: Buffer = await pngToIco(faviconPngs);
const faviconDest: string = resolve(root, "public", "favicon.ico");
writeFileSync(faviconDest, icoBuffer);