Apply codebase quality recommendations 1. Fix silent async failures — add console.error to VideoPlayerNode.play() catch and AutoTrackerNode initFromVideo catch so failures are visible in the console rather than silently discarded. 2. WASM error boundary — AutoTrackerNode now renders an in-video error message (below the drag hint) when OpenCV initialisation fails, giving the user actionable feedback instead of a silent no-op. 3. PlottableProperty registry — extract the 6. Standardize listener cleanup — AutoTrackerN uses a privateambda (same pattern as all other view nod instead of storing bound*-prefixed fields and calling unlink/remove directly from dispose(). Reds rem - #26
Merged
Conversation
1. Fix silent async failures — add console.error to VideoPlayerNode.play() catch and AutoTrackerNode initFromVideo catch so failures are visible in the console rather than silently discarded. 2. WASM error boundary — AutoTrackerNode now renders an in-video error message (below the drag hint) when OpenCV initialisation fails, giving the user actionable feedback instead of a silent no-op. 3. PlottableProperty registry — extract the nine kinematics quantities from KinematicsGraphNode into a new canonical file (src/screen-name/graph/kinematics-plottable-properties.ts) with a buildKinematicsPlottableProperties(model) factory. Adding a new physical quantity now requires a single-file edit. 4. Model-view transform safety — add SimModel.pixelToModelCoords(Vector2) as the single, named entry point for converting pixel/scene coordinates to model coordinates. Update AutoTrackerNode and DigitizingOverlayNode to use it; update the tracksProperty INVARIANT comment to reference the new method instead of the raw MVT call. 5. Graph subsystem documentation — replace the one-liner doc comment on ConfigurableGraph with a full subsystem overview: file table, data-flow diagram, gesture-coordination guidance, and visibility/axis-selection notes. 6. Standardize listener cleanup — AutoTrackerNode now uses a private disposeAutoTrackerNode lambda (same pattern as all other view nodes) instead of storing bound*-prefixed fields and calling unlink/remove directly from dispose(). Redundant bound* class fields removed. https://claude.ai/code/session_01JerFgrXUb6fycACVYTA971
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.