Skip to content

docs: document hardcoded colors compliance carve-out #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veillette merged 1 commit into from
Sep 5, 2026
+4 −4
Merged

docs: document hardcoded colors compliance carve-out #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@ micrometer, mirror tilt) only reach their useful precision via shift-arrow.

## Compliance carve-outs

- **`src/common/view/spectralColor.ts` and `sourceColor.ts` construct colours in code.** The
compliance grep flags `new Color(...)` and `encodeSrgb(...)` as possible hardcoded colours.
They are not theme colours — they are the output of a wavelength-to-colour computation, which
is physics, not styling. Every *themeable* colour lives in `InterferometryLabColors.ts`.
- **Hardcoded colors:** `src/common/view/spectralColor.ts` and `sourceColor.ts` construct colours in
code. The compliance grep flags `new Color(...)` and `encodeSrgb(...)` as possible hardcoded
colors. They are not theme colours — they are the output of a wavelength-to-colour computation,
which is physics, not styling. Every *themeable* colour lives in `InterferometryLabColors.ts`.
`scenery-phet`'s `VisibleColor` is deliberately not used for anything that gets summed, for the
reasons in the implementation notes.
- **`tests/memory-leak.test.ts` diverges from the template**: its `forceGC()` takes a predicate
Expand Down