Skip to content

docs: document hardcoded colors compliance carve-out #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veillette merged 1 commit into from
Sep 5, 2026
Merged

docs: document hardcoded colors compliance carve-out #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,12 +128,11 @@ Full convention:
inherited through `extends`, and the tests import src modules that use the
WebGPU flag namespaces, so the test project includes
`src/common/field/gpu/webgpu-globals.d.ts` alongside `tests`.
- **`rgbToCss` in `ColorMap.ts`** — flagged by the compliance scan as a possible
hardcoded colour because it builds an `rgb(...)` string. It is a *format* helper,
not a palette: the components it is handed come either from the temperature ramp
(a quantitative encoding, deliberately not themed) or from a
`ProfileColorProperty` by way of `FieldRenderStyle`. Nothing in it chooses a
colour, and it is the single such helper in the sim.
- **Hardcoded colors:** `rgbToCss` in `ColorMap.ts` is flagged by the compliance scan because it
builds an `rgb(...)` string. It is a *format* helper, not a palette: the components it is handed
come either from the temperature ramp (a quantitative encoding, deliberately not themed) or from a
`ProfileColorProperty` by way of `FieldRenderStyle`. Nothing in it chooses a colour, and it is the
single such helper in the sim.
- **No `src/common/TimeModel.ts`.** The template's composable timer does not fit:
the engine's simulated time is set by the stability-limited step, not by
accumulating `dt`, so `FieldSimulationModel` owns `isPlayingProperty` and
Expand Down