Skip to content

Optimize get_top_traders to only fetch requested candidate set #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ameeribro4-sudo merged 1 commit into from
Jul 21, 2026
Merged

Optimize get_top_traders to only fetch requested candidate set #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions peerx-contracts/counter/portfolio.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,20 +881,15 @@ impl Portfolio {
}

/// Get the top N traders by PnL (leaderboard)
/// Capped at top 100 for safety
/// Returns Vec<(Address, i128)>: list of (user, pnl) pairs sorted by PnL descending
/// Time complexity: O(1) - precomputed top 100
/// Time complexity: O(limit) — iterates only up to the requested count.
pub fn get_top_traders(&self, env: &Env, limit: u32) -> Vec<(Address, i128)> {
let max_limit: u32 = 100;
let actual_limit = if limit > max_limit { max_limit } else { limit };

let mut result = Vec::new(env);
let len = self.top_traders.len() as usize;
let limit_usize: usize = actual_limit as usize;
let cap = if len < limit_usize { len } else { limit_usize };
let len = self.top_traders.len();
let cap = if (len as u32) < limit { len } else { limit as usize };

for i in 0..cap {
if let Some(trader) = self.top_traders.get(i as u32) {
for i in 0..cap as u32 {
if let Some(trader) = self.top_traders.get(i) {
result.push_back(trader);
}
}
Expand Down
14 changes: 5 additions & 9 deletions peerx-contracts/counter/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,17 +319,12 @@ fn apply_trader_limit(
traders: Vec<(Address, i128)>,
limit: u32,
) -> Vec<(Address, i128)> {
let max_limit = if limit > 100 { 100 } else { limit };
let mut result = Vec::new(env);
let len = traders.len() as usize;
let cap = if len < max_limit as usize {
len
} else {
max_limit as usize
};
let len = traders.len() as u32;
let cap = if len < limit { len } else { limit };

for i in 0..cap {
if let Some(entry) = traders.get(i as u32) {
if let Some(entry) = traders.get(i) {
result.push_back(entry);
}
}
Expand Down Expand Up @@ -775,7 +770,8 @@ impl CounterContract {
.get(&())
.unwrap_or_else(|| Portfolio::new(&env));

let traders = portfolio.get_top_traders(&env, 100);
let candidate_limit = if limit > 100 { limit } else { limit.max(100) };
let traders = portfolio.get_top_traders(&env, candidate_limit);
env.storage().instance().set(
&TOP_TRADERS_CACHE_KEY,
&CachedTopTraders {
Expand Down
Loading