Conversation
|
@anthonypapetti Sorry it took me so long to get to this. In the future I will trigger builds faster. However, it looks like these changes resulted in a few test cases failing, see here for example. Can you resolve these issues? Thanks. |
Sounds good, I'll take a look at it. Thanks. |
api/bag_dataset.cpp
Outdated
| hid_t GopenProtector2(hid_t loc_id, const char *name, hid_t dapl_id) { | ||
| hid_t id = -1; | ||
| try { | ||
| id = H5Dopen2(loc_id, name, dapl_id); |
There was a problem hiding this comment.
Looks like a copy-paste type here. Should this be calling H5Gopen2 instead of H5Dopen2?
There was a problem hiding this comment.
Thanks, fixed that. Probably will not fix tests but it's good to have anyway
2 participants
Fixes #105
This creates protector functions that wrap the functions H5DFOpen() and H5GFOpen in try/catch statements in order to prevent a segmentation fault, and returns -1 on a fault to properly catch it and continue the program gracefully.