Repository navigation
test(jsonforms-renderers): cover ArrayControl conditional required asterisk - #122
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
Package/jsonforms-renderers
5 tasks done
ginaxu1
force-pushed
the
test/jsonforms-array-conditional-required-asterisk
branch
from
October 16, 2026 06:22
ee218df to
395d0c1
Compare
ginaxu1
added
enhancement
…terisk The ArrayControl unit suite mocks useIsRequired, so pin if/then array required behaviour with a real JsonForms render test. Co-authored-by: Cursor <cursoragent@cursor.com>
ginaxu1
force-pushed
the
test/jsonforms-array-conditional-required-asterisk
branch
from
October 16, 2026 06:34
395d0c1 to
3ef610f
Compare
sthanikan2000
approved these changes
Oct 16, 2026
ginaxu1
deleted the
test/jsonforms-array-conditional-required-asterisk
branch
October 16, 2026 06:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #118 (review): the unit tests mock
useIsRequired, so conditional-array asterisk behaviour was not covered by a committed test.Adds a jsdom render test with the real JsonForms provider for an
allOf/if/thenschema that requires the array, including when items are already present.Test plan
vitest run src/renderers/ArrayControl.required.test.tsx