Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ginaxu1
marked this pull request as draft
October 12, 2026 00:36
Contributor
Author
|
Awaiting scope confirmation by Poorima in https://github.com/LSFLK/lsf-govtech-tnsw/issues/149#issuecomment-6115676289 |
github-actions
Bot
added
Package/jsonforms-renderers
Contributor
Author
|
Updated for the confirmed rule from Poornima https://github.com/LSFLK/lsf-govtech-tnsw/issues/149#issuecomment-6119098256
|
ginaxu1
marked this pull request as ready for review
October 13, 2026 14:53
Prefill a search-select from a sibling field while it is empty, without overwriting a value the trader already set. Needed so NPQS consignee country can default from importing country without a JSON Forms COPY rule. Co-authored-by: Cursor <cursoragent@cursor.com>
tsc flagged 'type' being specified twice when spreading the shared country object shape into the SearchSelect defaultFrom schema fixtures. Co-authored-by: Cursor <cursoragent@cursor.com>
Match confirmed GeNS-style rules: Consignee Country stays editable, but follows Importing Country whenever that sibling changes. Co-authored-by: Cursor <cursoragent@cursor.com>
ginaxu1
force-pushed
the
feat/search-select-default-from
branch
from
October 13, 2026 14:53
97b6b42 to
8c826c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-search.defaultFromonSearchSelectControlso a field can mirror a sibling search-select value: fill while empty, and overwrite whenever the sibling changes. The field stays editable between sibling changes.search-select-modes.mdand covers empty-copy / sibling-change overwrite / user-edit-until-sibling-change / clear-refill / readonly with tests.Test plan
vitest run src/renderers/SearchSelectControl.test.tsx(17 passing)@opennsw/jsonforms-renderers, verify in trader-app: selecting importing country fills empty consignee country; editing consignee is allowed until importing country changes again (then consignee follows); clearing consignee refills from importing countryNotes
0.11.0on purpose — release uses the separate version-bump workflow after merge.x-searchkeys until this package is published and apps pick it up.