Repository navigation
Conversation
These fields are only required when Review Outcome is approve (allOf), so JSONForms never sets ControlProps.required and the red * is missing. Mark them in the title so officers see they are mandatory when shown. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Blendsheet reference and levy are required only when Review Outcome is approve (allOf), so JSONForms never sets ControlProps.required. Drop the title "*" hack and set uiSchema options.required so TextControl/NumberControl can show the same red asterisk as other required fields. Co-authored-by: Cursor <cursoragent@cursor.com>
2 of 3 tasks
ginaxu1
changed the title
Aravinda-HWK
previously approved these changes
Oct 15, 2026
Rely on ui-packages useIsRequired for the approve-path asterisk. Keep then.required for reference_number and levy_amount, and constrain levy_amount with exclusiveMinimum 0 and multipleOf 0.01. Co-authored-by: Cursor <cursoragent@cursor.com>
ginaxu1
changed the title
Contributor
Author
|
Updated to match OpenNSW/ui-packages#112
|
ginaxu1
changed the title
ginaxu1
changed the title
Contributor
Author
|
Not needed, remaining UX is #172 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/LSFLK/lsf-govtech-tnsw/issues/180
Summary
exclusiveMinimum: 0(fix(sltb): require a positive assessed levy on blend sheet approval #159 / fix(sltb-v2): require a positive assessed levy on blend sheet approval #165). Values like1000and1000.50are valid;0and negatives are not.multipleOf: 0.01to express cents. That is incorrect for this field: AJV rejects many valid positives (e.g.10.2) because of floating-pointmultipleOfchecks. Reverted ine2d7aef. Net diff vs main is empty.*when the field is required on approve, and blocking-/+/ewhile typing, need fix(jsonforms-renderers): show required asterisk for conditionally required fields ui-packages#112.Test plan
-5/0→ error;1000/1000.50/10.2→ accept*; signed keys blocked on levy input