Repository navigation
feat(taskflow): pass consumer-owned feedback field for display messages through on handles #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chathura-de-silva
wants to merge
15
commits into
OpenNSW:main
Choose a base branch
from
chathura-de-silva:feat/250-handle-declared-per-state-messages-for-post-action-feedback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
bc8708a
feat(taskflow): pass consumer-owned feedback field for display messag…
chathura-de-silva 16b0f41
docs(taskflow): document the pass-through messages field on handles
chathura-de-silva 23a808d
feat(taskflow): pass consumer-owned feedback field for display messag…
chathura-de-silva 49f6d35
docs(taskflow): document the pass-through messages field on handles
chathura-de-silva 396a8ca
Merge branch 'feat/250-handle-declared-per-state-messages-for-post-ac…
chathura-de-silva 239aa86
Merge remote-tracking branch 'upstream/main' into feat/250-handle-dec…
chathura-de-silva 3ddb31a
docs(taskflow): say messages keeps its JSON value, not its exact bytes
chathura-de-silva 21d8801
feat(taskflow): pass consumer-owned feedback field for display messag…
chathura-de-silva 32407f5
docs(taskflow): document the pass-through messages field on handles
chathura-de-silva 4449291
docs(taskflow): say messages keeps its JSON value, not its exact bytes
chathura-de-silva e6212b8
Merge branch 'feat/250-handle-declared-per-state-messages-for-post-ac…
chathura-de-silva 8de10b7
Merge remote-tracking branch 'upstream/main' into feat/250-handle-dec…
chathura-de-silva e24390a
Merge remote-tracking branch 'upstream/main' into feat/250-handle-dec…
chathura-de-silva 2e9207b
Merge remote-tracking branch 'upstream/main' into feat/250-handle-dec…
chathura-de-silva d66a13d
Merge remote-tracking branch 'upstream/main' into feat/250-handle-dec…
chathura-de-silva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we enforce the type more specific?
We can define the
Messagestruct ads follows:Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally avoided doing this to allow the consumer to decide the format and keep core away from deciding what is/what type the feedback format is. Will do if needed (with Mushrafs feedback as you said.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This make sense. Downstream can define what's the config they willing to have. Let's wait for review from others.