Repository navigation
control: drive the ATK ZERO, and let a mouse state its own lift-off range - #189
Merged
Merged
Conversation
The ZERO does not speak the 0xff02 EEPROM protocol the existing ATK driver implements, so the "ATK driver (0x373b) likely covers" note on the VXE Zero Normal row was wrong: that vendor id alone is not enough. The family uses the BITMOUSE channel on usage page 0xff05, added in OpenMouse-Project/mouse-protocol. Pin the two PIDs verified on hardware and let the PID universe in the test import them from the protocol package, so the row cannot drift. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ange Wiring the BITMOUSE driver up exposed three things the app assumed. A driver the app does not name is treated as Pulsar. `pulsarClient()` is a negative test — anything not in DEDICATED falls through to the Pulsar explorer — so connecting an ATK ZERO failed on `client.describeCollections is not a function`. The client joins DM_CLASSES, beside the older ATK, Lamzu and WLMouse drivers whose surface it shares. Cards come from BY_FAMILY, not from the status. `ui.showAdvancedSection` opens the section but `sleep` and `debounce` stay false until the family is in the table, so both cards were missing even though the driver reported values for them. "atk-bitmouse" gets the same DIRECT_MODE entry as "atk". Lift-off was three stops for everyone. `liftOffDistance` has only Low, Medium and High, so a mouse that tunes lift-off continuously — the ATK ZERO runs 0.7 mm to 1.7 mm in eleven steps — had ten of its settings thrown away. Drivers can now report a `liftOffScale`, and the card renders a slider over the raw device codes labelled with the millimetres the driver supplies, so the scale stays in the driver and any brand can use the control. The coarse field is still reported alongside it, and a driver that sets no scale keeps the three stops exactly as before. Sensor sampling mode was likewise Teevolution-only; a generic row now shows whenever a status carries `sensorMode`. Ultra Long Range gets a toggle against the new `longRangeMode` field. Also maps both ATK ZERO product ids to atk-zero.png. The art itself goes through an artwork request, as public/devices/README.md asks. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
# Conflicts: # src/app/cards/AdvancedCards.tsx # src/device/controller.ts # src/device/types.ts # src/supported-mice.test.ts
Also bumps @openmouse/protocol lockfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge of #159 onto current control-panel, resolving conflicts against #163's long-range-mode/turbo-mode/button-combination additions (both PRs added overlapping Pulsar toggle plumbing) plus an unused-import conflict in supported-mice.test.ts. Raised the JS bundle budget to 800 kB for the new ATK ZERO driver. Closes #159.