Repository navigation
UI #1237
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| export class BodyTooLarge extends Error {} | ||
|
|
||
| export async function boundedRequest(request, limit) { | ||
| if (Number(request.headers.get("Content-Length")) > limit) throw new BodyTooLarge(); | ||
| if (!request.body) return request; | ||
| const reader = request.body.getReader(); | ||
| const chunks = []; | ||
| let size = 0; | ||
| try { | ||
| while (true) { | ||
| const { done, value } = await reader.read(); | ||
| if (done) break; | ||
| size += value.byteLength; | ||
| if (size > limit) { | ||
| await reader.cancel().catch(() => {}); | ||
| throw new BodyTooLarge(); | ||
| } | ||
| chunks.push(value); | ||
| } | ||
| } finally { | ||
| reader.releaseLock(); | ||
| } | ||
| const bytes = new Uint8Array(size); | ||
| let offset = 0; | ||
| for (const chunk of chunks) { | ||
| bytes.set(chunk, offset); | ||
| offset += chunk.byteLength; | ||
| } | ||
| const headers = new Headers(request.headers); | ||
| headers.delete("Content-Length"); | ||
| return new Request(request, { headers, body: bytes }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,48 @@ | ||||||
| function text(value, max) { | ||||||
| if (typeof value !== "string" || value.length > max) throw new Error("Invalid text"); | ||||||
|
Contributor
There was a problem hiding this comment. 🔎 Supported by static analysis
Reject empty embed-field names and values before the webhook call.
🐛 Suggested fix
 |
||||||
| return value; | ||||||
| } | ||||||
|
|
||||||
| export function feedbackPayload(input) { | ||||||
| if (!input || typeof input !== "object" || Array.isArray(input)) throw new Error("Invalid payload"); | ||||||
| const payload = { allowed_mentions: { parse: [] } }; | ||||||
| if (input.content !== undefined) payload.content = text(input.content, 2000); | ||||||
| if (input.embeds !== undefined) { | ||||||
| if (!Array.isArray(input.embeds) || input.embeds.length > 10) throw new Error("Invalid embeds"); | ||||||
| let total = 0; | ||||||
| payload.embeds = input.embeds.map((embed) => { | ||||||
| if (!embed || typeof embed !== "object" || Array.isArray(embed)) throw new Error("Invalid embed"); | ||||||
| const result = {}; | ||||||
| for (const [key, limit] of [["title", 256], ["description", 4096]]) { | ||||||
| if (embed[key] !== undefined) { result[key] = text(embed[key], limit); total += result[key].length; } | ||||||
| } | ||||||
| if (embed.color !== undefined) { | ||||||
| if (!Number.isInteger(embed.color) || embed.color < 0 || embed.color > 0xffffff) throw new Error("Invalid color"); | ||||||
| result.color = embed.color; | ||||||
| } | ||||||
| if (embed.fields !== undefined) { | ||||||
| if (!Array.isArray(embed.fields) || embed.fields.length > 25) throw new Error("Invalid fields"); | ||||||
| result.fields = embed.fields.map((field) => { | ||||||
| const name = text(field?.name, 256); | ||||||
| const value = text(field?.value, 1024); | ||||||
| total += name.length + value.length; | ||||||
| return { name, value, ...(typeof field.inline === "boolean" ? { inline: field.inline } : {}) }; | ||||||
| }); | ||||||
| } | ||||||
| if (embed.footer !== undefined) { | ||||||
| const value = text(embed.footer?.text, 2048); | ||||||
| total += value.length; | ||||||
| result.footer = { text: value }; | ||||||
| } | ||||||
| if (embed.timestamp !== undefined) { | ||||||
| const value = text(embed.timestamp, 64); | ||||||
| if (!Number.isFinite(Date.parse(value))) throw new Error("Invalid timestamp"); | ||||||
|
Contributor
There was a problem hiding this comment. 🔎 Supported by static analysis
Validate the embed timestamp format before
🐛 Suggested fix
Committable suggestion
|
||||||
| result.timestamp = value; | ||||||
| } | ||||||
| return result; | ||||||
| }); | ||||||
| if (total > 6000) throw new Error("Embeds too long"); | ||||||
| } | ||||||
| if (!payload.content && !payload.embeds?.length) throw new Error("Empty feedback"); | ||||||
| return payload; | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎 Supported by static analysis
Script executed:
sed -n '1,180p' build/check-bundle-size.tsRepository: OpenMouse-Project/openmouse
Length of output: 2002
Script executed:
Repository: OpenMouse-Project/openmouse
Length of output: 3130
Document the 18,000-byte preview-fixtures allowance in the README.
The README states a flat JavaScript limit of 3,240,000 bytes.
build/check-bundle-size.tsenforces that limit only when nopreview-fixtures-*asset exists indist/assets. When such an asset exists, the checker allows 3,258,000 bytes. A production build can passnpm run sizewith a JavaScript total the README describes as over budget.📝 Suggested README correction
Correct the README in the same PR. Contributors use this text as the build budget, so the documented limit must match the enforced limit.
Committable suggestion