Repository navigation
fix(profiles): explain the empty Logitech profile list and how to fill it - #1226
Merged
Merged
Conversation
…l it A Logitech mouse that G HUB has never linked stores no onboard profiles, so the list was empty with no guidance — the exact report in issue #516. The Set up button (write factory profiles without G HUB) already existed but sat unlabeled next to an unexplained list, and formats without a captured factory image had no Set up option at all. The empty list now carries a note that says why it is empty (G HUB writes the profiles on first link) and routes the user: to the Set up button when a captured factory image exists for the format, otherwise to "open G HUB once and link the mouse, then reload profiles here". The "Click a profile to edit it" hint only renders once there are profiles to click. Strings were added to every locale. Fixes #516
Contributor
|
Caution Review failedThe pull request is closed. Finishing Touches
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a Logitech mouse that G HUB has never linked, the profiles section showed an empty list with no explanation — the report in issue #516. G HUB only writes the per-device profile files the first time it links a mouse, so OpenMouse had nothing to read and the user had no idea why the list was empty or what to do.
What was already there
PR c0764ae (two days after the issue) added a "Set up profiles" button that writes the captured Logitech factory profiles into the mouse without G HUB, offered whenever the list is empty and a complete factory image exists for the profile format. That covered the main path, but two gaps remained:
hasCapturedFactoryProfilesis false for formats 6 and 7, perlogitech-factory.test.ts) never get a Set up button, so those users were still left with a silent empty list and no path forward.Fix
.profile-empty-notestyling insrc/styles/areas/library.css, using existing tokens.Checks
npm run build✓npm test✓ (0 failures)npm run size✓ (CSS 92%, JS 99% of budget)Fixes #516
Note
Add empty-state explanation to the onboard profiles list
The Profiles screen now shows a note when no onboard profiles exist. The note explains why the list is empty and picks between setup guidance and G HUB guidance, depending on whether setup profiles are available. The existing profile-list hint shows only when profiles exist. Adds the three new translation keys to all locale files in
src/i18n/locales/, plus styling in library.css.Macroscope summarized 90699c4.