Repository navigation
feat(games): custom games, game profile parity and custom game images - #1177
Draft
onyxhq-dev wants to merge 1 commit into
Draft
onyxhq-dev wants to merge 1 commit into
onyxhq-dev wants to merge 1 commit into
Conversation
- Games page: add a game or an app by picking its executable or choosing a running app. Custom games are kept by Bridge, not in the browser. - Custom games can have a picture, uploaded or taken from a pasted link, shown on the tile and on the game's profile page. Hovering the picture offers "Change image" for custom games only. - Game profiles cover the Logitech settings of the device page: DPI X and Y, lift-off, report rate, bunny hop, HITS, Apply now and side button assignments, with Host profile parity and a default profile. - Strings are added to every locale. - A game profile keeps a report rate for wired and for wireless (like the onboard profiles), and applies the one for the connection in use.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets you add your own games to the Games page, and brings Logitech game profiles to the same level as the Host profile in G HUB. Needs OpenMouse Bridge for all of it.
Custom games
Game profiles
Checks
npx tsc --noEmit,npm test(408 tests) andnpm run buildpass. The JS budget is raised from 2,800,000 to 2,825,000 bytes (measured 2,823,553), with a note inbuild/check-bundle-size.ts, asAGENTS.mdasks.Draft because it uses
MouseStatus.pollingRateWirelessHz,pollingRateWiredHzandhostButtonsfrom OpenMouse-Project/mouse-protocol#246. Once that is released,@openmouse/protocolinpackage.jsonneeds bumping to it, and the type check will pass in CI. Bridge side: OpenMouse-Project/OpenMouse-Bridge#32.Note
Add custom games with images, game profile parity, and Host-button editing
prepareGameImageto at most 800px/450 KiB.buildProfileViewhides the normal profile entry, DPI slots, and bunny-hop support; analog-button writes during a profile operation are no longer persisted to the mouse; ordinary pending-change flashing stays blocked during draft editing while Apply Now uses the internal staged flasher.Macroscope summarized 85d6a15.