Repository navigation
fix(finalmouse): hide the polling card for the Starlight X - #1049
Merged
Merged
Conversation
The Starlight X has no adjustable polling rate — PerfectPolling is a fixed pipeline — but it still reports one, so the Performance tab offered a rate selector that could not do anything (and 8k in particular is a no-op on the SLX). `supportedPollingRates` comes from the driver, and the driver now marks the SLX read-only, but the card should not render at all: `PerfectPollingCard` already stands in for the SLX's polling story. Gate `cardAvailability.polling` on `!isSlxStatus(status)`. The Ultralight X keeps the selector; the SLX loses it.
github-actions
Bot
added
type: bug
Deploying openmouse with
|
| Latest commit: |
8b54868
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c949a9c5.openmouse.pages.dev |
| Branch Preview URL: | https://fix-finalmouse-slx-hide-poll.openmouse.pages.dev |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The SLX polling card is excluded while the ULX card remains available. No actionable merge-blocking risk remains. Pre-merge checks ·
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly states the main change: hide the polling card for the Starlight X. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #213 (mouse-protocol side: OpenMouse-Project/mouse-protocol#221).
The Starlight X has no adjustable polling rate — PerfectPolling is a fixed pipeline — but it reports one, so the Performance tab rendered a rate selector that could not do anything (8k in particular is a no-op on the SLX).
supportedPollingRatescomes from the driver, and the driver now marks the SLX read-only, but the card should not render at all:PerfectPollingCardalready stands in for the SLX's polling story. So gate it in the app.Change
cardAvailability.pollingis now!isSlxStatus(status) && (...). The Ultralight X keeps the selector; the Starlight X loses it.the Finalmouse Starlight X has no polling card; the Ultralight X keeps itcovers both dongles.Verification
tsc --noEmitclean,npm testgreen (383 pass).mouse-protocolbranch from fix: restore OpenMouse Bridge handshake #221 (linked intonode_modules): green, so the app tolerates the SLX's emptysupportedPollingRates.Not in scope
The SLX device render is still a placeholder (
device-images.tsdeliberately falls back tounknown-device.pngbecause no SLX art exists in the R2 bucket). That is an artwork task, tracked separately.Summary by CodeRabbit