Repository navigation
fix(logitech): read Superlight 2 Lightspeed polling above 1000 Hz - #226
Merged
Merged
Conversation
0x8061's rate list is per link. A zero connection argument is the cable, so a receiver-attached Superlight 2 only advertised through 1000 Hz. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 2
✨ Finishing Touches
Comment |
|
🎉 This PR is included in version 0.42.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x8061takes a connection argument:0is the USB cable and1is Lightspeed. The list and the current-rate read were sent with0, so the mouse answered with the cable's 1 kHz mask. Lightspeed now asks for connection1. Firmware that keeps the capability bitmask on function0is checked when function0x10still stops at 1,000 Hz.Test plan
npx tsx --import ./scripts/fast-test-timers.mjs --test src/drivers/logitech/hidpp.test.tsMade with Cursor
Summary by CodeRabbit