Repository navigation
fix(razer): commit DeathAdder V3 polling with the second extended write - #225
Merged
Merged
Conversation
The wired 0x00b2 acknowledges selector 0x00 and keeps the old rate. OpenRazer follows it with selector 0x01 on the same 0x1f transaction. Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
added
type: bug
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly identifies the Razer DeathAdder V3 polling commit fix and matches the primary change in the pull request. |
| Linked Issues check | |
The PR addresses active issue #222. The wired DeathAdder V3 (0x00b2) now uses transaction 0x1f for the extended polling commit. The regression test sends selector 0x00 followed by selector `0x01… |
| Out of Scope Changes check | |
The changed production configuration and tests directly support issue #222. The changes distinguish the wired DeathAdder V3 transaction from the HyperPolling dongle transaction and verify the required… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3… |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
🎉 This PR is included in version 0.42.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1532:00b2) acknowledged an extended polling write and then read back the old rate, so 8,000 Hz stayed at 8,000 Hz after a change to 2,000 Hz (fixes [Razer] DeathAdder V3 (1532:00B2) wired: polling-rate write doesn't stick (DPI works) #222).0x00with selector0x01, both on transaction0x1f. This is not the HyperPolling dongle's0xffcommit.0x00b2now sends that second write.Test plan
npx tsx --import ./scripts/fast-test-timers.mjs --test src/drivers/razer/devices.test.ts src/drivers/razer/hid.test.ts1532:00b2), set polling from 8,000 Hz to 2,000 Hz and confirm the read-back matchesMade with Cursor
Summary by CodeRabbit