Skip to content

feat(ajazz): letters, digits and modifiers in the button catalog - #201

Merged
snekxs merged 1 commit into
mainfrom
feat/ajazz-letter-keys
Oct 12, 2026
Merged

feat(ajazz): letters, digits and modifiers in the button catalog#201
snekxs merged 1 commit into
mainfrom
feat/ajazz-letter-keys

Conversation

@snekxs

@snekxs snekxs commented Oct 12, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Follow-up to #200. A ticket-0156 user wants to map W to a side button, but the action list only had media/navigation keys.

The vendor's newKeyInfos.json (V1 device class) carries a full keyboard catalog, so add it: A-Z, 0-9, punctuation, numpad, and modifier keys, all type 16 with the HID usage in code2. Labels are checked for uniqueness in tests so the remap UI can't pick the wrong binding.

Testing: build + full suite (2370 pass).

Summary by CodeRabbit

  • New Features

    • Added support for mapping AJAZZ buttons to letters, numbers, punctuation, numpad keys, and additional keyboard controls.
    • Button remapping can now use letter keys such as W and A.

  • Tests

    • Added checks for keyboard action mappings and remapped button bindings.

@snekxs
feat(ajazz): letters, digits and modifiers in the button catalog
b70c029 
The key catalog only carried media and navigation actions, so a side
button could not be mapped to a normal key (e.g. W for movement). Add
the vendor's full keyboard set from newKeyInfos.json: A-Z, 0-9,
punctuation, numpad and modifier keys, all type-16 with the HID usage
in code2. Labels stay unique for the remap UI.
@github-actions github-actions Bot added type: enhancement PR title category: enhancement area: protocol Protocol codecs and shared types area: drivers Device drivers and transport integration area: tests Protocol and driver tests labels Oct 12, 2026
@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: OpenMouse-Project/mouse-protocol/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fa1dd1f0-0827-4ff9-b987-8dd3184420eb
📥 Commits

Reviewing files that changed from the base of the PR and between ca01d07 and b70c029.

📒 Files selected for processing (2)
  • src/ajazz/index.ts
  • src/drivers/ajazz/hid.test.ts
 ______________________________________________________
< Please wait while I pretend to understand your code. >
 ------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@snekxs
snekxs merged commit 43e8679 into main Oct 12, 2026
6 of 7 checks passed
@github-actions

github-actions Bot commented Oct 12, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 0.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area: drivers Device drivers and transport integration area: protocol Protocol codecs and shared types area: tests Protocol and driver tests released type: enhancement PR title category: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@snekxs