Skip to content

Roll main back to v1.0.0-beta.18 - #44

Merged
jazzstack merged 1 commit into
mainfrom
main-rollback
Oct 26, 2026
Merged

jazzstack merged 1 commit into
mainfrom
main-rollback

Conversation

@jazzstack

@jazzstack jazzstack commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

beta.19 is preserved on the dev-v1.0.0-beta.19 branch.

Note

Roll main back to v1.0.0-beta.18

Reverts main to the v1.0.0-beta.18 codebase. The package version in Cargo.toml drops from beta.19 to beta.18, and the @openmouse/protocol dependency in native-hid/package.json moves back to v0.42.2. This undoes a large set of beta.19 work, most notably:

  • Removes the custom games, local applications, custom-game images, image-from-URL, and default-profile GET API routes, plus the loopback Host/Origin request gate in api.rs
  • Reverts the desktop tray panel to the older card-based UI, removing the new compact Home/Settings panel and diagnostics view in desktop.rs
  • Strips the heavily validated updater (bounded downloads, verify_package, safe_entry_path, staging-directory guard, transaction scripts) back to the simpler beta.18 version in updater.rs
  • Removes native automation, HID device discovery, button listeners, and onboard DPI/polling/switch-mode status from drivers and the service state in service.rs
  • Reverts CI/release workflows: cargo test, Clippy, format checks, and the Linux startup test no longer run

Risk: this rollback removes many beta.19 security validations. updater.extract_archive_with_limits no longer enforces size limits or path checks, config.save no longer writes atomically, and api.rs no longer rejects non-loopback Host/Origin headers. Anyone relying on beta.19 behavior or config fields (tray_battery_style, hybrid_mode, custom_games, local_applications) will see them disappear.

Macroscope summarized af77a3e.

@github-actions github-actions Bot added area: native Native bridge and platform services area: devices HID access and device drivers area: overlay Desktop overlay area: packaging Installation and application assets area: documentation Documentation area: dependencies Dependency manifests and lockfiles area: ci Automation and build configuration labels Oct 26, 2026
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp

macroscopeapp Bot commented Oct 26, 2026

Copy link
Copy Markdown

Macroscope skipped reviewing this pull request. Per-review cost limit exceeded (workspace setting).

This review would cost an estimated $15.34, which exceeds your per-review limit of $10.00.

The top 3 files driving up this estimate:

File Diff Size Estimate
src/desktop.rs 89.63KB $3.46
src/service.rs 87.89KB $3.39
src/updater.rs 36.67KB $1.42

Tip

To get this pull request reviewed, you can:

  1. Comment @macroscope-app on this PR to request a manual review (monthly spend limits still apply).
  2. Exclude the file(s) above from review by adding a pattern to your .macroscope/ignore.md — note that creating this file replaces Macroscope's built-in default ignores rather than extending them.
  3. Raise your cost limit in your workspace billing settings.

Turn off this reminder going forward

@macroscopeapp

macroscopeapp Bot commented Oct 26, 2026

Copy link
Copy Markdown

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This is a cross-cutting rollback that changes production API, HID, profile, UI, installation, and update behavior. It also removes request-boundary checks and substantial self-update/archive safety controls, so the security and compatibility impact requires human review.

Notes:

  • Your repo's Minimum Blocking Severity is Off, so correctness findings do not automatically block approval.
  • Per-review cost limit exceeded (workspace setting). Approvability was decided on eligibility alone.

Review your spending limits in Billing settings, or comment @macroscope-app review this PR to bypass the limit and review now. You can add or adjust custom eligibility rules. Learn more.

@jazzstack
jazzstack merged commit 4c53685 into main Oct 26, 2026
8 of 9 checks passed
@snekxs
snekxs deleted the main-rollback branch October 29, 2026 08:10
onyxhq-dev pushed a commit to onyxhq-dev/OpenMouse-Bridge that referenced this pull request Oct 30, 2026
…t/main-rollback"

This reverts commit 4c53685, reversing
changes made to 5ce9214.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci Automation and build configuration area: dependencies Dependency manifests and lockfiles area: devices HID access and device drivers area: documentation Documentation area: native Native bridge and platform services area: overlay Desktop overlay area: packaging Installation and application assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant