Repository navigation
Release v1.0.0-beta.18 - #38
Conversation
Address review: prune_batteries ran after the client-session check, so polls skipped during a control-panel session never evicted stale entries.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This release updates package metadata and fixes stale battery entries not being pruned during control-panel HID sessions. The runtime change is localized to in-memory cleanup, with hardware reads still skipped during active sessions. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Bumps to 1.0.0-beta.18 and includes the review follow-up from #37 (prune stale batteries even during a HID session,
d8a31cd, which missed the #37 merge). Refs #36.After merge: tag
v1.0.0-beta.18on the merge commit to trigger release.yml.Note
Release v1.0.0-beta.18: fix battery pruning during HID sessions
Bumps the package version from 1.0.0-beta.17 to 1.0.0-beta.18 in Cargo.toml and updates Cargo.lock. In service.rs,
BridgeService.start_battery_monitornow runs battery-device discovery and in-memory pruning before the active HID-session check, so stale battery entries are removed every polling interval. Hardware battery reads still skip during a control-panel HID session.Macroscope summarized 445ffaf.
Summary by CodeRabbit