Skip to content

Release v1.0.0-beta.18 - #38

Merged
snekxs merged 2 commits into
mainfrom
release/v1.0.0-beta.18
Oct 22, 2026
Merged

snekxs merged 2 commits into
mainfrom
release/v1.0.0-beta.18

Conversation

@snekxs

@snekxs snekxs commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Bumps to 1.0.0-beta.18 and includes the review follow-up from #37 (prune stale batteries even during a HID session, d8a31cd, which missed the #37 merge). Refs #36.

After merge: tag v1.0.0-beta.18 on the merge commit to trigger release.yml.

Note

Release v1.0.0-beta.18: fix battery pruning during HID sessions

Bumps the package version from 1.0.0-beta.17 to 1.0.0-beta.18 in Cargo.toml and updates Cargo.lock. In service.rs, BridgeService.start_battery_monitor now runs battery-device discovery and in-memory pruning before the active HID-session check, so stale battery entries are removed every polling interval. Hardware battery reads still skip during a control-panel HID session.

Macroscope summarized 445ffaf.

Summary by CodeRabbit

  • Bug Fixes
    • Battery information is now refreshed during periods when battery reads are paused, preventing outdated entries from lingering.

snekxs and others added 2 commits October 22, 2026 16:11
Address review: prune_batteries ran after the client-session check, so
polls skipped during a control-panel session never evicted stale entries.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added area: native Native bridge and platform services area: dependencies Dependency manifests and lockfiles labels Oct 22, 2026
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between a0c7e78 and 445ffaf.

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing: 2
  • Cargo.toml
  • src/service.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

The battery monitor now prunes battery entries before checking for an active HID session. Battery reads remain paused during an active session. The package version changes to 1.0.0-beta.18.

Changes: Battery monitor update

Layer / File(s) Summary
Prune entries before the session check
src/service.rs, Cargo.toml
start_battery_monitor loads saved-profile devices and prunes battery entries before checking for an active HID session. Battery reads remain paused during the session. The package version changes to 1.0.0-beta.18.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related issues

  • OpenMouse-Project/OpenMouse-Bridge issue 36 reports stale HID device entries in the connected list. This change prunes battery entries during polls that occur while an HID session is active, but it does not establish that all reported duplicate cases are fixed.
  • OpenMouse-Project/Desktop issue 27 reports a stale or duplicate Bridge entry. This change addresses stale-entry pruning during HID sessions, but not the separate image and model-name problem.

Suggested reviewers: jazzstack

Merge Risk: ⚪ Minimal · up to 445ff

The battery monitor preserves paused reads during HID sessions while continuing stale-entry cleanup.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the beta.18 release. It matches the version bump and the release objective, although it does not mention the battery-monitor fix.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp

macroscopeapp Bot commented Oct 22, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved at 445ffaf

Macroscope's review found this PR approvable — This release updates package metadata and fixes stale battery entries not being pruned during control-panel HID sessions. The runtime change is localized to in-memory cleanup, with hardware reads still skipped during active sessions.

Notes:

  • Your repo's Minimum Blocking Severity is Off, so correctness findings do not automatically block approval.

You can add or adjust custom eligibility rules. Learn more.

@snekxs
snekxs merged commit d121642 into main Oct 22, 2026
10 checks passed
@snekxs
snekxs deleted the release/v1.0.0-beta.18 branch October 29, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: dependencies Dependency manifests and lockfiles area: native Native bridge and platform services

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant