Avoid checkpointing null decay samples - #459
Draft
acavelan wants to merge 1 commit into
Draft
Conversation
SimpleDecayingValue leaves its heterogeneous decay sample null until deployment, but checkpointing dereferenced it unconditionally. Skip the empty sample so assertion-enabled builds avoid undefined behavior without changing the checkpoint layout.
acavelan
changed the title
acavelan
marked this pull request as draft
August 5, 2026 15:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running OpenMalaria in debug mode results in the same error for scenarios 26, 29 and 35:
Which can be traced back to: https://github.com/acavelan/openmalaria/blob/cdba86848c6d00494dbe926236a237960b549d57/model/util/SimpleDecayingValue.h#L76
Current fix works but would result in a hidden error if a SimpleDecayValue is used in the model, outside of interventions.