Adding diagnostics for server.xml if not defined in liberty plugin config xml#399
Closed
venmanyarun wants to merge 2 commits into
Closed
Adding diagnostics for server.xml if not defined in liberty plugin config xml#399venmanyarun wants to merge 2 commits into
venmanyarun wants to merge 2 commits into
Conversation
…nfig xml Signed-off-by: Arun Venmany <arun.kumar.v.n@ibm.com>
venmanyarun
changed the title
Contributor
Author
|
Tested following scenarios
2.1 No serverXmlFile is defined in project liberty plugin configuration, ie, liberty-plugin-config.xml does not contain configFile element
* warning will shown in custom server.xml files such as server2.xml
2.2 custom serverXmlFile node is defined
All the above tests are performed while libertyDev is running as well, working fine |
Signed-off-by: Arun Venmany <arun.kumar.v.n@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding diagnostics for server.xml if not defined in liberty plugin config xml
FIxes #58
Current warning message :- WARNING: The current configuration file {fileName} is not configured with server defined in the Liberty Maven/Gradle plugin configuration. Liberty tools features remain active for this file, though it will not be copied to the target Liberty runtime.