Fix confusing "lefting" wording in character delete message - #4222
Merged
Conversation
The pending-deletion message read "It will be deleted lefting [date]!" which is not valid English and confused users into thinking deletion was imminent, when it actually meant the character could not yet be deleted. Changed to clearly state the character cannot be deleted until that date. Fixes OpenKore#128
Contributor
Author
|
Hi @sctnightcore small, low-risk wording fix closing a long-standing issue (#128) reported back in 2016. Would appreciate a review when you have a moment! |
alisonrag
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a character is scheduled for deletion but can't be deleted yet, OpenKore shows:
"lefting" isn't valid English and confuses users into thinking deletion is imminent, when it actually means the character cannot be deleted until that date. This was reported in #128 back in 2016 and a prior attempt (#97) was never merged.
Fix
Changed the message to clearly state the character cannot be deleted until that date, matching the tone of the sibling message right above it ("Deleting is possible since %s.").
Fixes #128