Added support for portamx as a destination supports SMF 2.0.x#105
Open
VBGAMER45 wants to merge 2 commits into
Open
Added support for portamx as a destination supports SMF 2.0.x#105VBGAMER45 wants to merge 2 commits into
VBGAMER45 wants to merge 2 commits into
Conversation
Signed-off-by: Jonathan <vbgamer45@gmail.com>
Contributor
|
hmm.. tests seem to be pretty outdated here. 😂 @VBGAMER45 there is quite some commented out code, is it there for a specific reason or it's just leftovers? |
Author
|
Just left overs. I did just do one for Elkarte to SMF 2.0 as well. |
That importer would also be useful. |
Contributor
|
Then better clean them up. ;) |
Note requires these changes for passwords to work in SMF https://www.simplemachines.org/community/index.php?topic=566721.0
Author
|
Meh i don't get github. I wanted to a separate for SMF looks like good merged here. |
Contributor
|
@VBGAMER45 if you clean up a bit the commented code the PR can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for portamx as a destination supports SMF 2.0.x
Signed-off-by: Jonathan vbgamer45@gmail.com