-
-
Notifications
You must be signed in to change notification settings - Fork 443
E1: external-import domain interfaces and models #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1f01c55
3056e22
cacfd2b
ad2695b
13c019d
3d30236
6c7cf8d
e59353b
9d93d1e
15e0d8a
cd12123
cb38a5f
f2a776e
c3da019
195578b
6b55e56
ff99c1e
c0a1783
4650649
c7e4a2f
c44b765
d9140ed
c79eaee
da568d7
9829d36
be9c574
2a5acb9
82315a9
0980417
c858b7c
ad313fd
3b2bb37
f04c0da
ac5a1d3
413136e
b5d5731
f02ec95
dca895b
8def6cc
a9e7000
843ebf2
f0004b7
1d7358e
c910464
8dbe575
d247b53
e6dceca
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,21 @@ | |
| <uses-permission android:name="android.permission.FOREGROUND_SERVICE_DATA_SYNC" /> | ||
| <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" /> | ||
|
|
||
| <!-- | ||
| Fallback visibility for installer-source classification when | ||
| QUERY_ALL_PACKAGES is denied on Android 11+. We need to recognise | ||
| these specific packages as install sources even without blanket | ||
| package visibility. | ||
| --> | ||
| <queries> | ||
| <package android:name="dev.imranr.obtainium.app" /> | ||
| <package android:name="dev.imranr.obtainium" /> | ||
| <package android:name="dev.imranr.obtainium.fdroid" /> | ||
| <package android:name="org.fdroid.fdroid" /> | ||
| <package android:name="com.android.vending" /> | ||
| <package android:name="com.aurora.store" /> | ||
| </queries> | ||
|
Comment on lines
+27
to
+34
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check what identifier the codebase already uses for Obtainium elsewhere
# (e.g. installer-source allow-lists, telemetry constants, classifier code),
# to confirm the manifest <queries> stays in sync.
rg -nP --type=kt -C2 'dev\.imranr\.obtainium(\.[\w]+)?'
rg -nP -C2 'obtainium' --iglob '!**/*.lock' --iglob '!**/build/**'Repository: OpenHub-Store/GitHub-Store Length of output: 25817 Add the F‑Droid package identifier and sync across installer detection. The manifest is missing Suggested update for manifest <queries>
<package android:name="dev.imranr.obtainium.app" />
- <package android:name="dev.imranr.obtainium" />
+ <package android:name="dev.imranr.obtainium.fdroid" />
<package android:name="org.fdroid.fdroid" />
<package android:name="com.android.vending" />
<package android:name="com.aurora.store" />
</queries>Also update 🤖 Prompt for AI Agents |
||
|
|
||
| <application | ||
| android:name=".app.GithubStoreApp" | ||
| android:allowBackup="true" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restrict broad shell permissions for checkout/proxy commands.
Line 14 and Line 15 add wildcard permissions that materially expand destructive and network-capable operations (
git checkout *,rtk proxy *). This weakens the default safety boundary for automated command execution.Consider removing these from persistent allowlist, or narrowing to explicit safe patterns (specific args/targets) and requiring manual approval for all other invocations.
Suggested hardening diff
🤖 Prompt for AI Agents