Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Load MySQL connection settings through a small configuration helper.\n- Require
TRAFFIC_TWIN_DB_USERandTRAFFIC_TWIN_DB_PASSWORDfrom the environment instead of embedding a root password in source.\n- Document optional host, port, and database settings.\n- Add unit and AST regression tests that prevent a password literal from being passed toconnect()again.\n\n## Impact\nThe repository published a reusable database password and encouraged every deployment to use the same privileged account (CWE-798). The secret should also be rotated and removed from deployment history after this change is adopted.\n\n## Validation\n-python -m unittest discover -s tests -p test_database_config.py -v\n- 5 tests passed in Ubuntu 22.04 under VMware.