Repository navigation
fix: reject junction IDs that escape output directory - #178
Merged
Merged
Conversation
donghaiwang
approved these changes
Oct 18, 2026
Author
|
已审核提交 |
liuao08
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Validate the junction ID before creating an output directory.\n- Reject absolute paths, path separators, Windows drive-relative paths, NUL bytes, and any resolved path outside the configured output directory.\n- Add regression tests for valid and malicious junction IDs.\n\n## Impact\nA crafted V2X log line could use
../in the junction ID and causev2x_latency.logto be created or overwritten outside the configured output directory with the process user's permissions (CWE-22).\n\n## Validation\n-python -m unittest discover -s tests -p test_split_data_security.py -v\n- 5 tests passed in Ubuntu 22.04 under VMware.