Preserve annotated dataclass metadata - #2
Merged
Conversation
|
👀 Human Input Needed → Pair Review Briefing |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| # Try to get type hints, fall back to __annotations__ if resolution fails | ||
| try: | ||
| type_hints = get_type_hints(dataclass_type) | ||
| type_hints = get_type_hints(dataclass_type, include_extras=True) |
There was a problem hiding this comment.
With include_extras=True, ParameterInfo.param_type becomes Annotated[NestedDataclass, ...] for annotated nested fields, so UnifiedParameterAnalyzer.analyze_nested() no longer recognizes it with dataclasses.is_dataclass(param_info.param_type). That regresses nested dataclass source tagging for fields that worked before this change because get_type_hints() stripped the wrapper.
Severity: medium
🤖 Was this useful? React with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves
Annotatedmetadata at the dataclass signature-analysis authority so downstream form projections receive the declared nominal type. Includes the 0.1.8 package bump and focused regression coverage.\n\nVerification: 100 tests passed; wheel and sdist pass twine check.