Accelerate nested form construction - #2
Merged
Conversation
trissim
marked this pull request as ready for review
July 30, 2026 18:06
|
👀 Human Input Needed → Pair Review Briefing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Repeated nested-widget construction paid for redundant full-map scans and intermediate layout reflows. ObjectState already owns the immutable field topology, so PyQT-reactive can consume that projection without duplicating semantic state or caching QObjects.
Impact
A representative 148-row form improved from about 400 ms to 289 ms median declared-field completion in the final local run while preserving the exact 21-manager topology.
Validation
258 passed54 passed