Restore persisted timeline state when loading history - #6
Merged
Conversation
|
👀 Human Input Needed → Pair Review Briefing |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| "Loaded ObjectState history could not restore its current snapshot." | ||
| ) | ||
| if restored_at_head: | ||
| cls._current_head = None |
There was a problem hiding this comment.
When histories saved at live head are loaded, time_travel_to_snapshot() fires history-change callbacks while _current_head is still set to the head snapshot; this line then resets it without firing another callback. UI subscribers that refresh from those callbacks can observe get_current_snapshot_index()/is_time_traveling() as time-traveling and never learn that the restored timeline is back at live head.
Severity: medium
🤖 Was this useful? React with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification