Skip to content

G2P-5806 fix: improve responsiveness of UI widget components #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shibu-narayanan merged 1 commit into from
Oct 16, 2026
Merged

G2P-5806 fix: improve responsiveness of UI widget components #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 72 additions & 44 deletions ui/ui-widgets/src/components/PanelRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,53 @@ export interface PanelRendererProps {
isEditMode?: boolean;
}

const PANEL_LAYOUT_CSS = `
.panel-horizontal-grid {
display: grid;
width: 100%;
min-width: 0;
grid-template-columns: minmax(0, 1fr);
gap: 16px;
}
.panel-horizontal-grid > .panel-nested {
min-width: 0;
max-width: 100%;
position: relative;
}
.panel-horizontal-divider {
display: none;
}
.panel-widget-row {
display: flex;
flex-direction: column;
width: 100%;
min-width: 0;
gap: 0;
}
@media (min-width: 1024px) {
.panel-horizontal-grid {
grid-template-columns: repeat(var(--panel-columns, 1), minmax(0, 1fr));
gap: 0;
}
.panel-horizontal-grid > .panel-nested {
grid-column: span var(--panel-span, 1);
}
.panel-horizontal-grid > .panel-nested.panel-nested-pad-left {
padding-left: 40px;
}
.panel-horizontal-grid > .panel-nested.panel-nested-pad-right {
padding-right: 40px;
}
.panel-horizontal-divider {
display: block;
}
.panel-widget-row {
flex-direction: row;
gap: 16px;
}
}
`;

export const PanelRenderer = ({
panel,
dataSourceRequestHandler,
Expand All @@ -21,9 +68,10 @@ export const PanelRenderer = ({
const orientation = panel['panel-orientation'] || 'vertical';
const nestedPanels = panel.panels || [];
const widgets = panel.widgets || [];
const isHorizontalGrid = orientation === 'horizontal' && nestedPanels.length > 0;

const getContainerClassAndStyle = () => {
if (orientation === 'horizontal' && nestedPanels.length > 0) {
const getContainerClassAndStyle = (): { className: string; style: CSSProperties } => {
if (isHorizontalGrid) {
let totalColumns = 0;
nestedPanels.forEach((nestedPanel) => {
const columnSpan = nestedPanel['panel-column-span'] || 1;
Expand All @@ -33,15 +81,13 @@ export const PanelRenderer = ({
totalColumns = Math.max(totalColumns, nestedPanels.length);

return {
className: 'grid',
style: { gridTemplateColumns: `repeat(${totalColumns}, minmax(200px, 1fr))` },
className: 'panel-horizontal-grid',
style: { ['--panel-columns' as string]: String(totalColumns) },
};
}
return {
className: orientation === 'horizontal'
? 'flex flex-row'
: 'flex flex-col',
style: { gap: orientation === 'horizontal' ? '16px' : '0px' },
className: orientation === 'horizontal' ? 'panel-widget-row' : 'flex flex-col',
style: {},
};
};

Expand All @@ -58,48 +104,28 @@ export const PanelRenderer = ({
{nestedPanels.map((nestedPanel, index) => {
const isLastPanel = index === nestedPanels.length - 1;
const isFirstPanel = index === 0;
const nestedOrientation = nestedPanel['panel-orientation'] || 'vertical';
const columnSpan = nestedPanel['panel-column-span'];

const getNestedPanelStyle = (): CSSProperties => {
if (orientation === 'horizontal') {
const baseStyle: CSSProperties = {
minWidth: '200px',
paddingRight: !isLastPanel ? '40px' : undefined,
paddingLeft: !isFirstPanel ? '40px' : undefined,
position: 'relative',
};

if (nestedOrientation === 'vertical' && columnSpan && columnSpan > 1) {
return {
...baseStyle,
gridColumn: `span ${columnSpan}`,
minWidth: 'auto',
};
}

return baseStyle;
}
const columnSpan = nestedPanel['panel-column-span'] || 1;

if (columnSpan && columnSpan > 1) {
const width = columnSpan * 200;
return {
width: `${width}px`,
maxWidth: '100%',
flexShrink: 0,
};
}
return { width: '100%' };
};
const nestedPanelStyle: CSSProperties = isHorizontalGrid
? { ['--panel-span' as string]: String(columnSpan) }
: { width: '100%', maxWidth: '100%', minWidth: 0 };

const nestedPanelStyle = getNestedPanelStyle();
const nestedClassName = isHorizontalGrid
? [
'panel-nested',
!isFirstPanel ? 'panel-nested-pad-left' : '',
!isLastPanel ? 'panel-nested-pad-right' : '',
]
.filter(Boolean)
.join(' ')
: 'w-full min-w-0';

return (
<Fragment key={nestedPanel['panel-id'] || `panel-${index}`}>
<div
className={orientation === 'horizontal' ? 'min-w-200 relative' : 'w-full'}
className={nestedClassName}
style={nestedPanelStyle}
data-panel-column-span={columnSpan || undefined}
data-panel-column-span={columnSpan > 1 ? columnSpan : undefined}
>
<PanelRenderer
panel={nestedPanel}
Expand All @@ -110,6 +136,7 @@ export const PanelRenderer = ({
/>
{orientation === 'horizontal' && !isLastPanel && (
<div
className="panel-horizontal-divider"
style={{
position: 'absolute',
right: 0,
Expand Down Expand Up @@ -143,8 +170,9 @@ export const PanelRenderer = ({
<div
className={`panel panel-${orientation}`}
data-panel-id={panel['panel-id']}
style={orientation === 'horizontal' ? { width: '100%' } : {}}
style={{ width: '100%', minWidth: 0, maxWidth: '100%' }}
>
<style>{PANEL_LAYOUT_CSS}</style>
{content}
</div>
);
Expand Down
34 changes: 30 additions & 4 deletions ui/ui-widgets/src/components/SectionBuilder/JSONEditorPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ export const JSONEditorPanel: React.FC<JSONEditorPanelProps> = ({
flex: '1 1 0%',
width: '100%',
minHeight: 0,
minWidth: 0,
padding: '0 16px 16px',
boxSizing: 'border-box',
}}
Expand All @@ -213,19 +214,32 @@ export const JSONEditorPanel: React.FC<JSONEditorPanelProps> = ({
display: 'flex',
justifyContent: 'space-between',
alignItems: 'center',
flexWrap: 'wrap',
flexShrink: 0,
gap: '12px',
}}
>
<div style={{ display: 'flex', alignItems: 'center', gap: '12px', minWidth: 0 }}>
<div style={{ fontWeight: 600, fontSize: '16px', color: 'var(--owt-color-text)' }}>
<div style={{ display: 'flex', alignItems: 'center', gap: '12px', flex: '1 1 12rem', flexWrap: 'wrap', minWidth: 0 }}>
<div
title={t?.('sectionBuilder.jsonEditor') || 'JSON Editor'}
style={{
fontWeight: 600,
fontSize: '16px',
color: 'var(--owt-color-text)',
minWidth: 0,
overflow: 'hidden',
textOverflow: 'ellipsis',
whiteSpace: 'nowrap',
}}
>
{t?.('sectionBuilder.jsonEditor') || 'JSON Editor'}
</div>
<div
style={{
display: 'flex',
alignItems: 'center',
gap: '6px',
minWidth: 0,
color: statusIsOk ? 'var(--owt-color-success)' : 'var(--owt-color-error)',
}}
>
Expand All @@ -234,13 +248,25 @@ export const JSONEditorPanel: React.FC<JSONEditorPanelProps> = ({
width: '12px',
height: '12px',
borderRadius: '50%',
flexShrink: 0,
background: statusIsOk ? 'var(--owt-color-success)' : 'var(--owt-color-error)',
}}
/>
<span style={{ fontSize: '12px' }}>{statusLabel}</span>
<span
title={statusLabel}
style={{
fontSize: '12px',
minWidth: 0,
overflow: 'hidden',
textOverflow: 'ellipsis',
whiteSpace: 'nowrap',
}}
>
{statusLabel}
</span>
</div>
</div>
<div style={{ display: 'flex', alignItems: 'center', gap: '8px', flexShrink: 0 }}>
<div style={{ display: 'flex', alignItems: 'center', flexWrap: 'wrap', gap: '8px', flexShrink: 0 }}>
<button
type="button"
onClick={handleValidate}
Expand Down
Loading
Loading