fix: enhance cache cleaning in InspectorCommand to include layout and…#195
Merged
Conversation
… full page caches
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the MageForge mageforge:theme:inspector CLI command’s cache reset behaviour so enabling/disabling the frontend inspector more reliably takes effect by clearing additional Magento cache types.
Changes:
- Expanded
InspectorCommand::cleanCache()to cleanconfig,layout,full_page, andblock_htmlcaches (instead of onlyconfig). - Updated the command output message to reflect the broader cache cleaning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the cache cleaning logic in the
InspectorCommandto clear additional cache types, ensuring a more thorough cache reset when the command is executed.Cache management improvements:
cleanCachemethod from onlyconfigto also includelayout,full_page, andblock_html, and updated the output message accordingly inInspectorCommand.php.… full page caches