Add SoilDyn to dev-tc #3126
Open
Add SoilDyn to dev-tc #3126
+7,240
−423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- update calcoutput and add a routine to get the stiffness matrix
Added regression_test_controllers target as it was mistakenly removed
Reverted changes made in attempt to get SoilDyn regression tests to pass. May be good to revisit these changes later.
This code was added for SoilDyn but was applied to all SubDyn cases. This change moves the code inside the related SubDyn block and only applies it if SoilDyn is enabled.
… load calculation. Hydrodyn doesn't need hydrostatic loads when calculating dYdu and perturbing velocities/accelerations. Resulted in 20% speedup.
…rID_None when entering the function. Therefore, each function doesn't need to set ErrMsg = "" at the beginning which reduces some overhead.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
deslaughter
added
the
Module: SoilDyn
Contributor
There was a problem hiding this comment.
Pull request overview
This PR integrates the SoilDyn module into the OpenFAST dev-tc branch. SoilDyn was originally developed for OpenFAST 3.X as part of the OC6 project to model soil-pile interactions, specifically for coupling with the REDWIN DLL. This update adapts SoilDyn for the new glue code infrastructure.
Key Changes:
- Addition of SoilDyn module source files and build configuration
- Integration with FAST glue code for mesh mapping and module initialization
- New regression test case OC6_phaseII
- Updates to support Windows DLL loading for both SoilDyn and OrcaFlex
Reviewed changes
Copilot reviewed 42 out of 45 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/soildyn/* | Complete SoilDyn module implementation including source, registry, driver, and I/O |
| vs-build/SoilDyn/* | Visual Studio project files for Windows builds |
| vs-build/RunRegistry.bat | Added SoilDyn to registry build script |
| modules/openfast-library/src/FAST_* | Glue code updates for SoilDyn integration and mesh mappings |
| modules/subdyn/src/SD_FEM.f90 | Logic to detect soil stiffness from SoilDyn |
| reg_tests/CTestList.cmake | New OC6_phaseII regression test |
| modules/wakedynamics/src/WakeDynamics.f90 | Fixed DCM_logMap function call signature |
| modules/seastate/src/SeaSt_WaveField.f90 | Removed redundant ErrMsg initializations |
| modules/nwtc-library/src/NWTC_Base.f90 | Improved error message concatenation logic |
| docs/source/install/index.rst | Renamed ORCA_DLL_LOAD to WIN_DLL_LOAD |
Comments suppressed due to low confidence (1)
modules/soildyn/src/driver/SoilDyn_Driver_Subs.f90:1
- Corrected spelling of 'WrsCr' to 'WrScr'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
It looks good to me. Just a couple of comments:
|
RBergua
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge (supersedes #986)
Feature or improvement description
The SoilDyn module was developed as part of the OC6 project. It is designed specifically for coupling to the REDWIN dynamic linked library (DLL) for modeling soil-pile interactions. This set of DLL was developed by NGI in 2018 as part of the REDWIN project and includes three soil interaction models (https://www.ngi.no/eng/Projects/REDWIN-reduce-wind-energy-cost/#Reports-and-publications).
This module also supports a very simple soil stiffness interaction matrix, primarily for testing. There is a placeholder for a P-Y curve approach in the code, but this feature has not been fully developed.
Related issue, if one exists
Impacted areas of the software
Adds SoilDyn module and adds associated functions and meshes to
FAST_FuncsandFAST_Mapping.Additional supporting information
SoilDyn was originally developed for OpenFAST 3.X, but wasn't fully integrated. This PR updates SoilDyn for the new glue code.
Publications:
Test results, if applicable
A new test was added using a simple stiffness matrix. Unfortunately, the REDWIN DLL is proprietary and Windows only so it couldn't be integrated to the regression test suite.