Skip to content

Add toggle fast forward binding#32

Open
kunal-sharda wants to merge 1 commit intoOpenEmu:masterfrom
kunal-sharda:toggle-fast-forward
Open

Add toggle fast forward binding#32
kunal-sharda wants to merge 1 commit intoOpenEmu:masterfrom
kunal-sharda:toggle-fast-forward

Conversation

@kunal-sharda
Copy link

Adds a separate Toggle Fast Forward global binding while preserving the existing hold and fast forward action. References OpenEmu/OpenEmu#4886

Additions:

  • adds a new global binding identifier and binding name
  • exposes Toggle Fast Forward in Controls
  • latches fast-forward in OESystemResponder using separate held/toggled state
  • leaves the existing core fast-forward runtime behavior unchanged

Manual tests:

  • bind Toggle Fast Forward in the settings
  • press once: fast-forward stays enabled
  • press again: returns to normal speed
  • existing Fast Forward binding still works as hold
  • mixed hold/toggle interactions behave correctly

Tests: no automated tests added. I'm willing to add if this is an ask.

@kunal-sharda
Copy link
Author

I know there was already a fast forward commit with a sliding scale, but I wanted a toggle locally. Hopefully this can be helpful? Let me know if I need to change anything, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant