Sync CI workflows with embedded-rust-template#15
Sync CI workflows with embedded-rust-template#15jerrysxie wants to merge 1 commit intoOpenDevicePartnership:mainfrom
Conversation
- Merge separate clippy and hack jobs into unified hack-clippy job with target matrix (x86_64-unknown-linux-gnu, thumbv8m.main-none-eabihf) - Add stricter clippy lint groups: suspicious, correctness, perf, style - Add --locked flag to cargo check, test, deny, and msrv jobs - Add cargo clippy --tests step to test job - Add new machete job to detect unused dependencies - Add --locked to nostd workflow cargo check Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Synchronizes this repository’s GitHub Actions CI workflows with the latest embedded-rust-template, tightening linting and improving dependency/toolchain determinism.
Changes:
- Consolidates clippy + feature-powerset checks into a single
hack-clippymatrix job (toolchain + target). - Adds
--lockedto multiple Cargo invocations for more reproducible CI. - Introduces a
machetejob to detect unused Cargo dependencies.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/check.yml |
Unifies hack+clippy, tightens clippy lint groups, adds --locked in more jobs, and adds cargo-machete job. |
.github/workflows/nostd.yml |
Adds --locked to the no-std cargo check invocation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| components: clippy | ||
| - name: cargo install cargo-hack | ||
| uses: taiki-e/install-action@cargo-hack | ||
| # intentionally no target specifier; see https://github.com/jonhoo/rust-ci-conf/pull/4 |
There was a problem hiding this comment.
The comment about having “intentionally no target specifier” is now inaccurate since the command includes --target ${{ matrix.target }}. Please update or remove the comment/link so it matches the current invocation.
| # intentionally no target specifier; see https://github.com/jonhoo/rust-ci-conf/pull/4 | |
| # Run clippy over all feature combinations for each target in the matrix. |
| - name: Install ${{ matrix.toolchain }} | ||
| uses: dtolnay/rust-toolchain@stable | ||
| with: | ||
| toolchain: ${{ matrix.toolchain }} | ||
| target: ${{ matrix.target }} | ||
| components: clippy |
There was a problem hiding this comment.
In hack-clippy, the action ref is dtolnay/rust-toolchain@stable while the job installs a matrix toolchain (stable/beta). For consistency with the msrv job (which uses @master when toolchain: is variable) and to avoid any ambiguity about what ref is expected to support, consider using the same ref pattern here.
Summary
Syncs CI workflows with the latest embedded-rust-template.
Changes
check.yml
nostd.yml
Unchanged