[PATCH v2] api: packet: clarify l2/l3/l4 pointer value when offset is too large#2325
Merged
MatiasElo merged 1 commit intoOpenDataPlane:masterfrom Mar 30, 2026
Conversation
odpbuild
changed the title
The l2/l3/l4 offset metadata of a packet may be larger than the length of
the packet e.g. after truncating the packet. Specify that in that case
odp_packet_{l2,l3,l4}_ptr() can return any pointer value, including NULL,
and any value for the remaining segment length.
This also implies that a returned null pointer does not necessarily mean
that the offset has not been set.
Clarify that even though the offset setting functions require the offset
not exceed packet data length, later packet truncation and pulling
may result in the offset exceeding packet data length.
Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com>
Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
JannePeltonen
force-pushed
the
api-pkt-invalid-layer-offset
branch
from
5579f3a to
8294179
Compare
odpbuild
changed the title
Collaborator
Author
|
v2: rebased and added review tag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The l2/l3/l4 offset metadata of a packet may be larger than the length of the packet e.g. after truncating the packet. Specify that in that case odp_packet_{l2,l3,l4}_ptr() can return any pointer value, including NULL, and any value for the remaining segment length.
This also implies that a returned null pointer does not necessarily mean that the offset has not been set.
Clarify that even though the offset setting functions require the offset not exceed packet data length, later packet truncation and pulling may result in the offset exceeding packet data length.