[PATCH v9] api: timer: refactor periodic timer expiration event configuration#2320
Merged
MatiasElo merged 2 commits intoOpenDataPlane:masterfrom Mar 27, 2026
Merged
Conversation
odpbuild
changed the title
MatiasElo
reviewed
Mar 4, 2026
psavol
reviewed
Mar 4, 2026
psavol
reviewed
Mar 4, 2026
psavol
reviewed
Mar 4, 2026
psavol
reviewed
Mar 4, 2026
psavol
reviewed
Mar 4, 2026
psavol
reviewed
Mar 4, 2026
psavol
reviewed
Mar 4, 2026
psavol
reviewed
Mar 4, 2026
psavol
reviewed
Mar 4, 2026
psavol
reviewed
Mar 4, 2026
TuomasTaipale
force-pushed
the
dev/add_timer_last_ev_4
branch
from
1b2976d to
2c0ed70
Compare
odpbuild
changed the title
TuomasTaipale
force-pushed
the
dev/add_timer_last_ev_4
branch
from
2c0ed70 to
4b1aa83
Compare
odpbuild
changed the title
TuomasTaipale
force-pushed
the
dev/add_timer_last_ev_4
branch
from
4b1aa83 to
e7d1225
Compare
odpbuild
changed the title
psavol
reviewed
Mar 17, 2026
psavol
reviewed
Mar 17, 2026
TuomasTaipale
force-pushed
the
dev/add_timer_last_ev_4
branch
from
e7d1225 to
79a5476
Compare
odpbuild
changed the title
shijith
reviewed
Mar 23, 2026
TuomasTaipale
force-pushed
the
dev/add_timer_last_ev_4
branch
from
79a5476 to
abb58ec
Compare
odpbuild
changed the title
MatiasElo
added
the
API spec OK
MatiasElo
reviewed
Mar 25, 2026
Collaborator
MatiasElo
left a comment
MatiasElo
left a comment
There was a problem hiding this comment.
Checked API and implementation.
| typedef struct { | ||
| /** Destination queue | ||
| * | ||
| * When timer expires, a ODP_EVENT_TIMEOUT event is sent to this queue. The event is from |
Collaborator
There was a problem hiding this comment.
Typo: an ODP_EVENT_TIMEOUT
TuomasTaipale
force-pushed
the
dev/add_timer_last_ev_4
branch
from
abb58ec to
31f99bd
Compare
odpbuild
changed the title
MatiasElo
approved these changes
Mar 27, 2026
Collaborator
MatiasElo
left a comment
MatiasElo
left a comment
There was a problem hiding this comment.
Couple a ODP_EVENT_TIMEOUT typos still, but otherwise looks good.
TuomasTaipale
force-pushed
the
dev/add_timer_last_ev_4
branch
from
31f99bd to
b1cfd63
Compare
odpbuild
changed the title
MatiasElo
added
API Ready
Instead of configuring a single event to be sent for periodic timer expirations, application now configures a timeout pool to be created as part of timer pool creation. This enables more flexibility for implementations to control how they setup the periodic timer expiration signaling. Additionally, periodic timers are now allocated with the new `odp_timer_periodic_alloc()` function the parameters of which now house a combination of parameters from `odp_timer_alloc()` and `odp_timer_periodic_start_t`. In particular the `freq_multiplier` is now part of timer allocation which implementation can utilize in calculating needed timeout events for a timer as well as an application provided callback that can be used to initialize the user areas of the to-be-allocated timeout events. Lastly, periodic timer related function specifications clarified in places. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com> Reviewed-by: Shijith Thotton <sthotton@marvell.com>
Add tests for `odp_timeout_is_periodic()`. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
MatiasElo
force-pushed
the
dev/add_timer_last_ev_4
branch
from
b1cfd63 to
c210f6c
Compare
odpbuild
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of configuring a single event to be sent for periodic timer expirations, application now configures a timeout pool to be created as part of timer pool creation. This enables more flexibility for implementations to control how they setup the periodic timer expiration signaling.
Additionally, periodic timers are now allocated with the new
odp_timer_periodic_alloc()function the parameters of which now house a combination of parameters fromodp_timer_alloc()andodp_timer_periodic_start_t. In particular thefreq_multiplieris now part of timer allocation which implementation can utilize in calculating needed timeout events for a timer as well as an application provided callback that can be used to initialize the user areas of the to-be-allocated timeout events.Lastly, periodic timer related function specifications clarified in places.
v2:
v4:
v5:
v6:
v7:
odp_bench_timerv8: