feat(formulus-formplayer): align with ODE tokens and adopt @ode/components for chrome#328
Open
IamLRBA wants to merge 14 commits intoOpenDataEnsemble:devfrom
Open
feat(formulus-formplayer): align with ODE tokens and adopt @ode/components for chrome#328IamLRBA wants to merge 14 commits intoOpenDataEnsemble:devfrom
IamLRBA wants to merge 14 commits intoOpenDataEnsemble:devfrom
Conversation
Contributor
Author
… for component types
… for component types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Align formulus- formwith ODE tokens and adopt @ode/components for chrome`
Description
This PR addresses issue #291 for formulus-formplayer by:
Token alignment - Replacing hardcoded values (colors, spacing, borders, shadows) across formplayer with ODE design tokens from
@ode/tokens, consumed viatokens-adapter.tsand the MUI theme.ODE Button for chrome - Using
@ode/components/react-webButtonfor form navigation (Previous/Next) and Finalize screen actions, so key chrome elements match the ODE design system while form controls remain MUI-based.Decision: Keep MUI for form controls - The form UI is built on
@jsonforms/material-renderers(MUI-based).@ode/components(react-web) currently has Button, Input, Card, Badge, ButtonGroup only with no Select, Checkbox, Radio, Switch, DatePicker, or TextField-with-label. Custom renderers (Photo, Signature, File, etc.) also rely on MUI primitives.Replacing the Form UI with ODE would require custom JSON Forms renderers for every control type.
Full replacement is not feasible at the moment without expanding
@ode/componentsand building a new renderer set.We shall therefore keep MUI for form controls and only swap chrome (navigation and action buttons) to ODE.
Additional changes: lint/format fixes and added
NumberStepperRenderer.Type of Change
Component(s) Affected
Related Issue(s)
Closes/Fixes/Resolves: Closes #291 (formulus-formplayer portion)
Testing
Breaking Changes
Documentation Updates
Checklist
Thank you for contributing to Open Data Ensemble (ODE)!