Skip to content

fix(desktop): harden sqlite bindings install flow#112

Merged
Sun-sunshine06 merged 1 commit intomainfrom
fix/desktop-sqlite-bindings
Apr 19, 2026
Merged

fix(desktop): harden sqlite bindings install flow#112
Sun-sunshine06 merged 1 commit intomainfrom
fix/desktop-sqlite-bindings

Conversation

@Sun-sunshine06
Copy link
Copy Markdown
Collaborator

Summary

  • make the desktop sqlite binding installer invoke prebuild-install in a Windows/pnpm-safe way
  • allow the installer to skip missing Node prebuilds while still staging the Electron binding needed by the desktop app
  • add a runtime fallback + regression test for binding path resolution

Testing

  • corepack pnpm --filter @open-codesign/desktop test -- src/main/snapshots-db.binding.test.ts
  • corepack pnpm --filter @open-codesign/desktop typecheck
  • corepack pnpm exec biome check package.json apps/desktop/scripts/install-sqlite-bindings.cjs apps/desktop/src/main/snapshots-db.ts apps/desktop/src/main/snapshots-db.binding.test.ts

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • None.

Summary

  • Review mode: initial
  • No high-confidence issues were found in the added/modified lines of this diff.
  • Residual risks/testing gaps: docs/VISION.md and docs/PRINCIPLES.md are not present in this checkout (Not found in repo/docs), and the new install flow is only unit-tested at binding-path resolution level (no integration test coverage in this PR for postinstall scenarios like missing Node prebuild).

Testing

  • Not run (automation)

open-codesign Bot

Signed-off-by: Sun-sunshine06 <Sun-sunshine06@users.noreply.github.com>
@Sun-sunshine06 Sun-sunshine06 force-pushed the fix/desktop-sqlite-bindings branch from e3edc76 to 5e10b77 Compare April 19, 2026 14:13
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • None.

Summary

  • Review mode: follow-up after new commits
  • No high-confidence issues were found in the added/modified lines of this diff.
  • Residual risks/testing gaps: install-flow changes in apps/desktop/scripts/install-sqlite-bindings.cjs are not covered by integration tests for postinstall permutations (for example missing Node prebuild while Electron prebuild is present); only binding-path unit tests were added in this PR. docs/VISION.md and docs/PRINCIPLES.md are Not found in repo/docs in this checkout.

Testing

  • Not run (automation)

open-codesign Bot

@Sun-sunshine06 Sun-sunshine06 merged commit d11f36d into main Apr 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant