OpenConceptLab/ocl_issues#2315 | Updated Search Highlights dialog

[snyaggarwal]

Reworks the Search Highlights dialog per the acceptance criteria in OpenConceptLab/ocl_issues#2315:

• Renamed "Search Highlight" → "Match Details", "Search Score" → "Unified Score", "Search Raw Score" → "Raw Scores"
• Moved close button to top-right X (CloseIconButton)
• Scores displayed using color-coded chips consistent with the candidates tab, with per-algorithm raw score breakdown
• Added "Matched Attributes" section header; category names as sub-headers
• Improved synonyms readability (smaller font, tighter line-height, increased spacing)
• Extracted getScoreDetails and ScoreValueChip from Score.jsx for reuse
• Fixed truthy check on CIELMappedSources.length (was length, now length > 0)

[paynejd]

@snyaggarwal — Review notes. Overall this looks good and addresses all of the original acceptance criteria from #2315. A couple of things:

Suggested PR description (feel free to copy into the PR body):

Reworks the Search Highlights dialog per the acceptance criteria in OpenConceptLab/ocl_issues#2315:

• Renamed "Search Highlight" → "Match Details", "Search Score" → "Unified Score", "Search Raw Score" → "Raw Scores"
• Moved close button to top-right X (CloseIconButton)
• Scores displayed using color-coded chips consistent with the candidates tab, with per-algorithm raw score breakdown
• Added "Matched Attributes" section header; category names as sub-headers
• Improved synonyms readability (smaller font, tighter line-height, increased spacing)
• Extracted getScoreDetails and ScoreValueChip from Score.jsx for reuse
• Fixed truthy check on CIELMappedSources.length (was length, now length > 0)

Minor: key collision risk — In SearchHighlightsDialog.jsx, the raw scores list uses key={`${rawScore.algorithm}-${rawScore.score}`}. If two algorithms return the same score for a concept, the keys collide. Low probability but easy fix — append the array index:

{map(rawScores, (rawScore, index) => (
  <Stack
    key={`${rawScore.algorithm}-${rawScore.score}-${index}`}
    ...

Otherwise LGTM.

[snyaggarwal]

@paynejd updated PR

[paynejd]

LGTM — key collision fix looks good. All acceptance criteria from ocl_issues#2315 addressed. Approving.